Message-ID: <1431632112.2237.5.camel@sipsolutions.net> (sfid-20150514_213546_172893_B8801C49)
Subject: Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning
From: Johannes Berg <johannes@sipsolutions.net>
To: Gaston Gonzalez <gascoar@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	devel@driverdev.osuosl.org, arnd@arndb.de,
	gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org,
	joe@perches.com, navyasri.tech@gmail.com, julian.calaby@gmail.com
Date: Thu, 14 May 2015 21:35:12 +0200
In-Reply-To: <5553F48E.3050008@gmail.com> (sfid-20150514_030522_036209_6D0AE5EB)
References: <1429476231-6197-1-git-send-email-gascoar@gmail.com>
	 <20150420082441.GU10964@mwanda> <553C18B6.807@gmail.com>
	 <20150427101242.GR14154@mwanda> <554AD76E.7060605@gmail.com>
	 <20150508110328.GT14154@mwanda> <55527D6E.7090207@gmail.com>
	 <20150513083615.GS14154@mwanda> <5553F48E.3050008@gmail.com>
	 (sfid-20150514_030522_036209_6D0AE5EB)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Wed, 2015-05-13 at 22:04 -0300, Gaston Gonzalez wrote:

>  .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c      | 53
> ++--------------------
>  include/net/mac80211.h                             |  3 ++
>  net/mac80211/tkip.c                                |  9 ++--
>  3 files changed, 10 insertions(+), 55 deletions(-)

That doesn't seem right to me. Clearly, that's a staging driver that
ships its own 802.11 subsystem, and bears no existing relation to
mac80211. Exporting a mac80211 internal function to make such a driver
happy makes me very suspicious. That function might not be very mac80211
specific, but exporting it from mac80211 doesn't seem right, that
introduces a massive and mostly artificial dependency into the driver.

Now arguably that driver is in staging and that doesn't matter, but then
why even bother cleaning this up? It seems likely that a well-written
driver for this would use mac80211, and not have to bother with this at
all since it could then use ieee80211_get_tkip_rx_p1k() or
ieee80211_get_tkip_p2k() or the update_tkip_key() method.

So I'm not fond of this patch and without a *very very* good reason and
explanation I'm not going to merge the mac80211 part. It certainly
bothers me much less that a crappy staging driver has a few lines of
duplicated code than it would to export mac80211 internals that real
mac80211 drivers don't need.

johannes