Return-path: Received: from mail-lb0-f177.google.com ([209.85.217.177]:34240 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbbEXTDE (ORCPT ); Sun, 24 May 2015 15:03:04 -0400 MIME-Version: 1.0 In-Reply-To: <1432415812-1285-1-git-send-email-Larry.Finger@lwfinger.net> References: <1432415812-1285-1-git-send-email-Larry.Finger@lwfinger.net> Date: Sun, 24 May 2015 22:03:02 +0300 Message-ID: (sfid-20150524_210314_480133_DA4381B7) Subject: Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync() From: Haggai Eran To: Larry Finger Cc: gregkh@linuxfoundation.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, Stable , Sudip Mukherjee , Arek Rusniak Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 24 May 2015 at 00:16, Larry Finger wrote: > The driver is reporting a warning at kernel/time/timer.c:1096 due to calling > del_timer_sync() while in interrupt mode. Such warnings are fixed by calling > del_timer() instead. > > Signed-off-by: Larry Finger > Cc: Stable > Cc: Haggi Eran Hi, I haven't been using kernel v4.1 so I haven't seen this warning, but looking at the code it seems to originate from the two recent patches to remove _cancel_timer and _cancel_timer_ex. I see that there's another patch in lkml [1] that changes del_timer_sync back to del_timer in more places. Perhaps it could prevent other warnings like this in the future. Regards, Haggai [1] https://lkml.org/lkml/2015/5/15/226