Return-path: Received: from mail-pa0-f44.google.com ([209.85.220.44]:33823 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750769AbbEFJEB (ORCPT ); Wed, 6 May 2015 05:04:01 -0400 Received: by pacyx8 with SMTP id yx8so3778355pac.1 for ; Wed, 06 May 2015 02:04:00 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1419834253-18331-1-git-send-email-eliad@wizery.com> <1419834253-18331-6-git-send-email-eliad@wizery.com> <5512A9BC.5010902@pengutronix.de> <5512B6F2.8090407@pengutronix.de> From: Yegor Yefremov Date: Wed, 6 May 2015 11:03:40 +0200 Message-ID: (sfid-20150506_110409_632952_35111687) Subject: Re: [PATCH 06/13] wlcore: enable sleep during AP mode operation To: Eliad Peller Cc: Marc Kleine-Budde , "linux-wireless@vger.kernel.org" , Kobi Leibovitch , "kernel@pengutronix.de" , "Machani, Yaniv" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, May 6, 2015 at 10:32 AM, Eliad Peller wrote: > hi Yegor, > > On Mon, May 4, 2015 at 12:16 PM, Yegor Yefremov > wrote: >> On Wed, Mar 25, 2015 at 2:45 PM, Eliad Peller wrote: >>> On Wed, Mar 25, 2015 at 3:24 PM, Marc Kleine-Budde wrote: >>>> On 03/25/2015 01:58 PM, Eliad Peller wrote: >>>>> hi Marc, >>>>> >>>>> On Wed, Mar 25, 2015 at 2:27 PM, Marc Kleine-Budde wrote: >>>>>> On 12/29/2014 07:24 AM, Eliad Peller wrote: >>>>>>> From: Kobi L >>>>>>> >>>>>>> Enable ELP authorization in AP mode and enable the use >>>>>>> of the wakeup bit in the ELP register. >>>>>>> >>>>>>> Introduce AP role sleep configuration which is disabled >>>>>>> by default. When configured, it allows the AP to sleep >>>>>>> when ELP is authorized for it. >>>>>>> >>>>>>> Signed-off-by: Kobi Leibovitch >>>>>>> Signed-off-by: Arik Nemtsov >>>>>>> Signed-off-by: Eliad Peller >>>>>> >>>>>> [...] >>>>>> >>>>>> >>>>>> This patch requires a new firmware, loading of "wl18xx-conf.bin" from >>>>>> [1] fails with: >>>>>> >>>>>>> wlcore: ERROR configuration binary file size is wrong, expected 1226 got 1221 >>>>>> >>>>> thanks. seems you're right. >>>>> >>>>> anyway, note that this file is not actual fw, but only the default >>>>> configuration params. >>>>> you can just delete it, and the driver will load just fine. >>>>> you can then recreate it with something like: >>>>> cat /sys/kernel/debug/ieee80211/phy0/wlcore/wl18xx/conf > >>>>> /lib/firmware/ti-connectivity/wl18xx-conf.bin >>>>> >>>>> actually, i don't think it makes much sense to have this file in the >>>>> linux-firmware git at all. >>>>> i'll try handling it. >>>> >>>> Thanks, there are more file with size of ~1k, are they optional, too? >>>> What's the "error" message if these optional files are not present? >>>> >>> AFAIK, the other nvs files are basically required for proper operation. >>> >>>> From working with $CUSTOMERS I gained the impression, messages like >>>> "error failed to load...." for optional file don't shine the best light >>>> on Linux, a neutral "using default values" is far better. >>> i agree :) >> >> Added Yaniv Machani in CC. >> >> Any update on the wl18xx-conf.bin issue? This file is still in >> linux-firmware repo. >> > thanks for the reminder :) > > just sent a patch to fallback to default conf in case of invalid/outdated conf. Great. @Yaniv: but how to create a new conf with 1226 bytes for existing ini file? Yegor