Return-path: Received: from mail-ob0-f181.google.com ([209.85.214.181]:36181 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932313AbbFEPhG (ORCPT ); Fri, 5 Jun 2015 11:37:06 -0400 Received: by obbqz1 with SMTP id qz1so38933936obb.3 for ; Fri, 05 Jun 2015 08:37:05 -0700 (PDT) Message-ID: <5571C21E.1050101@lwfinger.net> (sfid-20150605_173710_830325_768B2283) Date: Fri, 05 Jun 2015 10:37:02 -0500 From: Larry Finger MIME-Version: 1.0 To: Taehee Yoo CC: linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/3] rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile References: <1433512898-30137-1-git-send-email-ap420073@gmail.com> In-Reply-To: <1433512898-30137-1-git-send-email-ap420073@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/05/2015 09:01 AM, Taehee Yoo wrote: > in the _rtl92c_phy_rf6052_config_parafile(), RF90_PATH_A and > RF90_PATH_B are same routine. so i remove one of these routine. > also the return routine is duplicated. so i remove it. > > Signed-off-by: Taehee Yoo > --- > drivers/net/wireless/rtlwifi/rtl8192cu/rf.c | 4 ---- > 1 file changed, 4 deletions(-) > The code changes are OK, but the commit message needs some work. The phrase "RF90_PATH_A and RF90_PATH_B are same routine" should be changed to "cases RF90_PATH_A and RF90_PATH_B call the same routine". Larry > diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c b/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c > index b878d56..8ce055c 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c > +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c > @@ -452,9 +452,6 @@ static bool _rtl92c_phy_rf6052_config_parafile(struct ieee80211_hw *hw) > udelay(1); > switch (rfpath) { > case RF90_PATH_A: > - rtstatus = rtl92cu_phy_config_rf_with_headerfile(hw, > - (enum radio_path) rfpath); > - break; > case RF90_PATH_B: > rtstatus = rtl92cu_phy_config_rf_with_headerfile(hw, > (enum radio_path) rfpath); > @@ -483,7 +480,6 @@ static bool _rtl92c_phy_rf6052_config_parafile(struct ieee80211_hw *hw) > } > } > RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, "<---\n"); > - return rtstatus; > phy_rf_cfg_fail: > return rtstatus; > } >