Return-path: Received: from mga03.intel.com ([134.134.136.65]:65080 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408AbbFHVjW (ORCPT ); Mon, 8 Jun 2015 17:39:22 -0400 Date: Mon, 8 Jun 2015 23:39:11 +0200 From: Samuel Ortiz To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Lauro Ramos Venancio , Aloisio Almeida Jr , Robert Dolca , linux-wireless@vger.kernel.org, kernel@pengutronix.de, Linus Walleij , Alexandre Courbot Subject: Re: [PATCH] NFC: PN544: use flags argument of devm_gpiod_get to set direction Message-ID: <20150608213911.GG5089@ribalta.mp.intel.com> (sfid-20150608_233926_184768_69714B0B) References: <1432020176-17343-1-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <1432020176-17343-1-git-send-email-u.kleine-koenig@pengutronix.de> Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Uwe, On Tue, May 19, 2015 at 09:22:56AM +0200, Uwe Kleine-K?nig wrote: > Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) > which appeared in v3.17-rc1, the gpiod_get* functions take an additional > parameter that allows to specify direction and initial value for output. > > Use this to simplify the driver. Furthermore this is one caller less > that stops us making the flags argument to gpiod_get*() mandatory. > > While touching this also do some minor coding style fixes. > > Fixes: 0a5942c8e148 ("NFC: Add ACPI support for NXP PN544") > Signed-off-by: Uwe Kleine-K?nig > --- > drivers/nfc/pn544/i2c.c | 43 +++++++++++-------------------------------- > 1 file changed, 11 insertions(+), 32 deletions(-) Applied to nfc-next, thanks. Cheers, Samuel.