Return-path: Received: from mail-wg0-f48.google.com ([74.125.82.48]:33323 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755964AbbFBI6o (ORCPT ); Tue, 2 Jun 2015 04:58:44 -0400 Date: Tue, 2 Jun 2015 10:58:40 +0200 From: Konrad Zapalowicz To: Sudip Mukherjee Cc: Johnny Kim , Rachel Kim , Dean Lee , Chris Park , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: wilc1000: fix warning while printing Message-ID: <20150602085840.GC5903@patagonia> (sfid-20150602_105853_695507_83668E16) References: <1433231814-4204-1-git-send-email-sudipm.mukherjee@gmail.com> <20150602082917.GB5903@patagonia> <20150602083532.GA5331@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20150602083532.GA5331@sudip-PC> Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/02, Sudip Mukherjee wrote: > On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote: > > On 06/02, Sudip Mukherjee wrote: > > > size_t should print using %zu, but here it was using %d and hence we > > > were getting warning while printing. > > > > > > Signed-off-by: Sudip Mukherjee > > > --- > > > > > > I think it will be easy to remove the other warnings if all the typedefs > > > are removed first. > > > > > > drivers/staging/wilc1000/wilc_spi.c | 2 +- > > > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- > > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c > > > index d0e7610..6d854fd 100644 > > > --- a/drivers/staging/wilc1000/wilc_spi.c > > > +++ b/drivers/staging/wilc1000/wilc_spi.c > > > @@ -404,7 +404,7 @@ static int spi_cmd_complete(uint8_t cmd, uint32_t adr, uint8_t *b, uint32_t sz, > > > #undef NUM_DUMMY_BYTES > > > > > > if (len2 > (sizeof(wb) / sizeof(wb[0]))) { > > > - PRINT_ER("[wilc spi]: spi buffer size too small (%d) (%d)\n", > > > + PRINT_ER("[wilc spi]: spi buffer size too small (%d) (%lu)\n", > > > > Hi, it seems that the above line should use %zu too. Am I correct or I'm > > missing something? > oops. my mistake. %lu is correct but i missed mentioning the warning > about long unsigned int in the commit message. Why %lu here and %zu in other places? I mean that it is the same size_t or I'm missing something? - konrad > regards > sudip