Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:48719 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbbG1QXh (ORCPT ); Tue, 28 Jul 2015 12:23:37 -0400 From: Kalle Valo To: "John W. Linville" CC: Vasanthakumar Thiagarajan , , Subject: Re: [PATCH] ath10k: remove NULL ptr deref in variable init of ath10k_monitor_vdev_start References: <1438024935-3946-1-git-send-email-linville@tuxdriver.com> <55B70EEF.9070205@qti.qualcomm.com> <20150728143124.GB17081@tuxdriver.com> Date: Tue, 28 Jul 2015 19:23:25 +0300 In-Reply-To: <20150728143124.GB17081@tuxdriver.com> (John W. Linville's message of "Tue, 28 Jul 2015 10:31:25 -0400") Message-ID: <87a8ug8d4y.fsf@kamboji.qca.qualcomm.com> (sfid-20150728_182340_768133_7FE43AD5) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: "John W. Linville" writes: > On Tue, Jul 28, 2015 at 10:41:11AM +0530, Vasanthakumar Thiagarajan wrote: >> On Tuesday 28 July 2015 12:52 AM, John W. Linville wrote: >> >In ath10k_monitor_vdev_start, chandef is initialized to NULL and then >> >channel is immediately thereafter initialized to chandef->chan (i.e. >> >NULL->chan). This appears to be some sort of cut-n-paste error, since >> >the same assignment is done later (i.e. after chandef has been properly >> >assigned to a non-NULL value). So, let's just remove this "brown paper >> >bag" typo/thinko... :-) >> > >> >Coverity CID #1309505 >> > >> >Signed-off-by: John W. Linville [...] >> There is a similar change integrated recently, >> https://github.com/kvalo/ath/commit/19be9e9a7ac7e6050eab426283d2a87593cf6e82 > > OK. I don't see much point in the NULL assignment for channel, but the main > point is to avoide the chandef->chan part. Yeah, that was an oversight in my review. Want to send a patch to fix that? :) -- Kalle Valo