Return-path: Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:28073 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759211AbbGHUXK (ORCPT ); Wed, 8 Jul 2015 16:23:10 -0400 From: Christophe JAILLET To: kvalo@codeaurora.org, brudley@broadcom.com, arend@broadcom.com, frankyl@broadcom.com, meuleman@broadcom.com Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH v2] brcmsmac: Use kstrdup to simplify code Date: Wed, 8 Jul 2015 22:22:46 +0200 Message-Id: <1436386966-16148-1-git-send-email-christophe.jaillet@wanadoo.fr> (sfid-20150708_222344_968266_F3D4636F) In-Reply-To: <1436383927-14010-1-git-send-email-christophe.jaillet@wanadoo.fr> References: <1436383927-14010-1-git-send-email-christophe.jaillet@wanadoo.fr> Sender: linux-wireless-owner@vger.kernel.org List-ID: Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve readability. Signed-off-by: Christophe JAILLET --- v2: fix the subject drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c b/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c index 4813506..8a6c077 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c +++ b/drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c @@ -1476,9 +1476,7 @@ struct brcms_timer *brcms_init_timer(struct brcms_info *wl, wl->timers = t; #ifdef DEBUG - t->name = kmalloc(strlen(name) + 1, GFP_ATOMIC); - if (t->name) - strcpy(t->name, name); + t->name = kstrdup(name, GFP_ATOMIC); #endif return t; -- 2.1.4