Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:50701 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753887AbbGXRDG (ORCPT ); Fri, 24 Jul 2015 13:03:06 -0400 From: Kalle Valo To: Vineet Gupta Cc: Peter Zijlstra , Ingo Molnar , Arnd Bergmann , , , Brett Rudley , Arend van Spriel , "Franky \(Zhenhui\) Lin" , "Hante Meuleman" , Pieter-Paul Giesberts , Daniel Kim , , , Subject: Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive References: <1436429599-10762-1-git-send-email-vgupta@synopsys.com> <1436429599-10762-3-git-send-email-vgupta@synopsys.com> Date: Fri, 24 Jul 2015 20:02:58 +0300 In-Reply-To: <1436429599-10762-3-git-send-email-vgupta@synopsys.com> (Vineet Gupta's message of "Thu, 9 Jul 2015 13:43:18 +0530") Message-ID: <87twstbi9p.fsf@kamboji.qca.qualcomm.com> (sfid-20150724_190329_964681_D8600A84) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Vineet Gupta writes: > There's already a generic implementation so use that instead. > --- > I'm not sure if the driver usage of atomic_or?() is correct in terms of > storage size of @val for 64 bit arches. > > Assuming LP64 programming model for linux on say x86_64: atomic_or() > callers in this driver use long (sana 64 bit) storage and pass it to > atomic_orr/atomic_or which downcasts it to 32 bits. Is that OK ? > --- > Cc: Brett Rudley > Cc: Arend van Spriel > Cc: "Franky (Zhenhui) Lin" > Cc: Hante Meuleman > Cc: Kalle Valo > Cc: Pieter-Paul Giesberts > Cc: Daniel Kim > Cc: linux-wireless@vger.kernel.org > Cc: brcm80211-dev-list@broadcom.com > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: netdev@vger.kernel.org > Cc: linux-arch@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Vineet Gupta > > Signed-off-by: Vineet Gupta What's the plan with this patch? Should I take it to my wireless-drivers-next tree or will someone else take it? -- Kalle Valo