Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:41148 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751293AbbG0KIw (ORCPT ); Mon, 27 Jul 2015 06:08:52 -0400 From: Kalle Valo To: Arend van Spriel Cc: Vineet Gupta , Vineet Gupta , Peter Zijlstra , Ingo Molnar , Arnd Bergmann , , , Brett Rudley , "Franky \(Zhenhui\) Lin" , Hante Meuleman , Pieter-Paul Giesberts , Daniel Kim , , , Subject: Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive References: <1436429599-10762-1-git-send-email-vgupta@synopsys.com> <1436429599-10762-3-git-send-email-vgupta@synopsys.com> <87twstbi9p.fsf@kamboji.qca.qualcomm.com> <55B2743F.6060304@synopsys.com> <55B4C0A8.9000909@broadcom.com> Date: Mon, 27 Jul 2015 13:08:43 +0300 In-Reply-To: <55B4C0A8.9000909@broadcom.com> (Arend van Spriel's message of "Sun, 26 Jul 2015 13:12:40 +0200") Message-ID: <871tftc3pw.fsf@kamboji.qca.qualcomm.com> (sfid-20150727_120918_091646_E44EF580) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Arend van Spriel writes: > On 07/24/2015 07:22 PM, Vineet Gupta wrote: >> On Friday 24 July 2015 08:02 PM, Kalle Valo wrote: >>> Vineet Gupta writes: >>> >>>>> There's already a generic implementation so use that instead. >>>>> --- >>>>> I'm not sure if the driver usage of atomic_or?() is correct in terms of >>>>> storage size of @val for 64 bit arches. >>>>> >>>>> Assuming LP64 programming model for linux on say x86_64: atomic_or() >>>>> callers in this driver use long (sana 64 bit) storage and pass it to >>>>> atomic_orr/atomic_or which downcasts it to 32 bits. Is that OK ? >>>>> --- >>>>> Cc: Brett Rudley >>>>> Cc: Arend van Spriel >>>>> Cc: "Franky (Zhenhui) Lin" >>>>> Cc: Hante Meuleman >>>>> Cc: Kalle Valo >>>>> Cc: Pieter-Paul Giesberts >>>>> Cc: Daniel Kim >>>>> Cc: linux-wireless@vger.kernel.org >>>>> Cc: brcm80211-dev-list@broadcom.com >>>>> Cc: Peter Zijlstra >>>>> Cc: Ingo Molnar >>>>> Cc: netdev@vger.kernel.org >>>>> Cc: linux-arch@vger.kernel.org >>>>> Cc: linux-kernel@vger.kernel.org >>>>> Signed-off-by: Vineet Gupta >>>>> >>>>> Signed-off-by: Vineet Gupta >>> What's the plan with this patch? Should I take it to my >>> wireless-drivers-next tree or will someone else take it? >> >> >> Per last discussion on this topic, Arend wanted to discuss abt this with Hante. >> I'm not taking it anyways so feel free to pick it up if you want ! > > Well, that was before your "timeline" clarification about the generic > function. One what tree is this patch based? Yeah, if this patch depends on another patch I need to know about it. Otherwise I might break something when I apply this patch. -- Kalle Valo