Return-path: Received: from mail-ob0-f172.google.com ([209.85.214.172]:33235 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752312AbbHJDiK (ORCPT ); Sun, 9 Aug 2015 23:38:10 -0400 Received: by obbhe7 with SMTP id he7so18805710obb.0 for ; Sun, 09 Aug 2015 20:38:09 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <55C4DDF5.6010901@lwfinger.net> References: <1438917073-5720-1-git-send-email-acelan.kao@canonical.com> <55C4DDF5.6010901@lwfinger.net> Date: Mon, 10 Aug 2015 11:38:09 +0800 Message-ID: (sfid-20150810_053826_418306_61003528) Subject: Re: [PATCH] rtlwifi: rtl8723be: disable FW control power save From: AceLan Kao To: Larry Finger Cc: linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Larry, I tried using "ips=0" today and found it's not working. I ping 8.8.8.8 and got below message within one hour. ping: sendmsg: No buffer space available Best regards, AceLan Kao. 2015-08-08 0:33 GMT+08:00 Larry Finger : > On 08/06/2015 10:11 PM, AceLan Kao wrote: >> >> There are many rtl8723be wifi unstable issues that wifi lost connection >> after working for a while. The wifi signal and status it's show connected >> also ifconfig have IP but can not connect to internet and filed to ping >> 8.8.8.8 >> The problem should result from the power saving controlled by firmware. >> I'd suggest to disable it by default and re-enable it after firmware fixes >> this issue. >> >> BTW. the firmware I tested from linux-firmware git tree is >> rtlwifi/rtl8723befw.bin >> be225d6 Update firmware for rtl8723be >> >> Signed-off-by: AceLan Kao > > > NACK for this patch. If you were to make this change, you should also change > the text in the MODULE_PARM_DESC() for this parameter. It shows a hard-coded > default. > > I am not sure this is a firmware problem as some users report that they need > to run with the "ips=0" option, not with "fwlps=0" as your patch would > force. Conversely, the driver works fine as is with other AP/environment > combinations. > > The Realtek engineer has told me that he is aware of problems with the > dynamic management for all the drivers, and that they are working on major > replacements; however, there is no timetable for the new code. > > If we make a change in the default power settings, I would prefer changing > inactiveps and its MODULE_PARM_DESC() text; however, that would have a > negative impact on power usage on the host. > > I have BCc'd the Realtek engineer and I hope to get his comments on this > change. > > Larry > >> --- >> drivers/net/wireless/rtlwifi/rtl8723be/sw.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/rtlwifi/rtl8723be/sw.c >> b/drivers/net/wireless/rtlwifi/rtl8723be/sw.c >> index 1017f02..02fe2cc 100644 >> --- a/drivers/net/wireless/rtlwifi/rtl8723be/sw.c >> +++ b/drivers/net/wireless/rtlwifi/rtl8723be/sw.c >> @@ -266,7 +266,7 @@ static struct rtl_mod_params rtl8723be_mod_params = { >> .sw_crypto = false, >> .inactiveps = true, >> .swctrl_lps = false, >> - .fwctrl_lps = true, >> + .fwctrl_lps = false, >> }; >> >> static struct rtl_hal_cfg rtl8723be_hal_cfg = { >> >