Return-path: Received: from mail-pd0-f178.google.com ([209.85.192.178]:32951 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753095AbbHTVL6 (ORCPT ); Thu, 20 Aug 2015 17:11:58 -0400 Date: Thu, 20 Aug 2015 14:11:52 -0700 From: Brian Norris To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Andrzej Hajda , linux-fbdev@vger.kernel.org, Michael Hennerich , linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, Lee Jones , Jean-Christophe Plagniol-Villard , linux-mtd@lists.infradead.org, Lauro Ramos Venancio , =?iso-8859-1?Q?S=F8ren?= Andersen , devel@driverdev.osuosl.org, Randy Dunlap , Masanari Iida , Jiri Kosina , Devendra Naga , Tomi Valkeinen , Kyungmin Park , Krzysztof Kozlowski , Greg Kroah-Hartman , Aloisio Almeida Jr , Jonathan Cameron , Stephen Warren , Urs =?iso-8859-1?Q?F=E4ssler?= , Adrian Hunter , Mauro Carvalho Chehab , Aya Mahfouz , George McCollister , Samuel Ortiz , Manfred Schlaegl , linux-omap@vger.kernel.org, Hartmut Knaack , Ulf Hansson , Antonio Borneo , Andrea Galbusera , Michael Welling , Fabian Frederick , Mark Brown , linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org, Lars-Peter Clausen , David Woodhouse , netdev@vger.kernel.org, linux-media@vger.kernel.org, Peter Meerwald Subject: Re: [PATCH 00/18] Export SPI and OF module aliases in missing drivers Message-ID: <20150820211152.GI74600@google.com> (sfid-20150820_231214_040844_83CFC9F5) References: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote: > Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches ^^^ I'm dying to know how this sentence ends :) > Patch #18 changes the logic of spi_uevent() to report an OF modalias if > the device was registered using OF. But this patch is included in the > series only as an RFC for illustration purposes since changing that > without first applying all the other patches in this series, will break > module autoloading for the drivers of devices registered using OF but > that lacks an of_match_table. I'll repost patch #18 once all the patches > in this series have landed. On a more productive note, the patches I've looked at look good to me. The missing aliases are a problem enough that should be fixed (i.e., part (b)). I'll leave the SPI framework changes to others to comment on. Brian