Return-path: Received: from mga14.intel.com ([192.55.52.115]:42915 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753287AbbHQBs2 (ORCPT ); Sun, 16 Aug 2015 21:48:28 -0400 Message-ID: <55D13D66.1050500@linux.intel.com> (sfid-20150817_034928_736738_CEB3FC12) Date: Mon, 17 Aug 2015 09:48:22 +0800 From: "Fu, Zhonghui" MIME-Version: 1.0 To: Emmanuel Grumbach CC: Johannes Berg , David Miller , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] net/wireless: enable wiphy device to suspend/resume asynchronously References: <55B9B3BA.6080406@linux.intel.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2015/7/30 13:55, Emmanuel Grumbach wrote: > On Thu, Jul 30, 2015 at 8:18 AM, Fu, Zhonghui > wrote: >> Enable wiphy device to suspend/resume asynchronously. This can improve >> system suspend/resume speed. >> > How will that impact the timing with respect to the suspend call > coming from the bus? > I think that a few drivers rely on the suspend call of the wiphy > device happening before the suspend call to the bus device. > Not sure though. Sorry for late reply. The suspend/resume timing of wiphy device and related devices will be ensured by their parent/child relationship. So, enabling wiphy device to suspend/resume asynchronously does not change any dependency. It can only take advantage of multicore and improve system suspend/resume speed. Thanks, Zhonghui > >> Signed-off-by: Zhonghui Fu >> --- >> net/wireless/core.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/net/wireless/core.c b/net/wireless/core.c >> index 2a0bbd2..bc5e68f 100644 >> --- a/net/wireless/core.c >> +++ b/net/wireless/core.c >> @@ -416,6 +416,7 @@ use_default_name: >> device_initialize(&rdev->wiphy.dev); >> rdev->wiphy.dev.class = &ieee80211_class; >> rdev->wiphy.dev.platform_data = rdev; >> + device_enable_async_suspend(&rdev->wiphy.dev); >> >> INIT_LIST_HEAD(&rdev->destroy_list); >> spin_lock_init(&rdev->destroy_list_lock); >> -- 1.7.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html