Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]:9717 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750928AbbHRLaz (ORCPT ); Tue, 18 Aug 2015 07:30:55 -0400 From: Kalle Valo To: Michal Kazior CC: , , , , , , Subject: Re: [PATCH/RFT 1/2] ath10k: add qca6164 support References: <1439469147-9408-1-git-send-email-michal.kazior@tieto.com> <1439469147-9408-2-git-send-email-michal.kazior@tieto.com> Date: Tue, 18 Aug 2015 14:30:46 +0300 In-Reply-To: <1439469147-9408-2-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 13 Aug 2015 14:32:26 +0200") Message-ID: <87d1ykdeah.fsf@kamboji.qca.qualcomm.com> (sfid-20150818_133058_703432_E9CC5D4C) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Michal Kazior writes: > This adds additional 0x0041 PCI Device ID > definition to ath10k for QCA6164 which is a 1 > spatial stream sibling of the QCA6174 (which is 2 > spatial stream chip). > > The QCA6164 needs a dedicated board.bin file which > is different than the one used for QCA6174. If the > board.bin is wrong the device will crash early > while trying to boot firmware. The register dump > will look like this: > > ath10k_pci 0000:02:00.0: firmware register dump: > ath10k_pci 0000:02:00.0: [00]: 0x05010000 0x000015B3 0x000A012D 0x00955B31 > ... > > Note the value 0x000A012D. > > Special credit goes to Alan Liu > for providing support > help which enabled me to come up with this patch. > > Signed-off-by: Michal Kazior As neither Michal nor me have QCA6174 and I'm reluctant to take untested patches, it would be great if someone could test this and tell us how it went. That way I feel safer to apply this. -- Kalle Valo