Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:34274 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751773AbbHMMC7 (ORCPT ); Thu, 13 Aug 2015 08:02:59 -0400 From: Kalle Valo To: Raja Mani CC: , Subject: Re: [PATCH 1/2] ath10k: refactor phyerr event handlers References: <1439373396-10828-1-git-send-email-rmani@qti.qualcomm.com> <87si7nmnjw.fsf@kamboji.qca.qualcomm.com> Date: Thu, 13 Aug 2015 15:02:47 +0300 In-Reply-To: <87si7nmnjw.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Thu, 13 Aug 2015 14:32:19 +0300") Message-ID: <87oaibmm54.fsf@kamboji.qca.qualcomm.com> (sfid-20150813_140303_659847_79FE592B) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Kalle Valo writes: > Raja Mani writes: > >> Existing phyerr event handlers directly uses phyerr header format >> (ie, struct wmi_phyerr and struct wmi_phyerr_event) in the code >> exactly on how firmware packs it. This is the problem in 10.4 fw >> specific phyerr event handling where it uses different phyerror >> header format. Before adding 10.4 specific handler, little bit of >> refactor is done in existing phyerr handlers. >> >> Two new abstracted structures (struct wmi_phyerr_ev_hdr_arg and >> struct wmi_phyerr_ev_arg) are introduced to remove dependency of using >> firmware specific header format in the code. So that firmware specific >> phyerror handlers can populate values to abstracted structures and >> the following code can use abstracted struct for further operation. >> >> .pull_phyerr_hdr is added newly to pull common phyerr header info >> like tsf, buf_len, number of phyerr packed. Existing .pull_phyerr >> handler is changed and called to parse every sub phyerrs in the event. >> >> Validated these refactoring on qca988x hw2.0 using fw 10.2.4 version. >> >> Signed-off-by: Raja Mani > > Thanks, applied. Actually I'll take it back, I dropped these as I see new warnings: drivers/net/wireless/ath/ath10k/wmi.c:3625:33: warning: restricted __le32 degrades to integer drivers/net/wireless/ath/ath10k/wmi.c:3627:38: warning: restricted __le32 degrades to integer drivers/net/wireless/ath/ath10k/wmi.c:3599:5: warning: symbol 'ath10k_wmi_10_4_op_pull_phyerr_ev' was not declared. Should it be static? -- Kalle Valo