Return-path: Received: from mail-wi0-f181.google.com ([209.85.212.181]:36319 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755272AbbIAKOy (ORCPT ); Tue, 1 Sep 2015 06:14:54 -0400 Received: by wibz8 with SMTP id z8so26633093wib.1 for ; Tue, 01 Sep 2015 03:14:53 -0700 (PDT) From: Helmut Schaa To: linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net, Helmut Schaa Subject: [RFC 2/2] mac80211: Copy tx'ed beacons to monitor mode Date: Tue, 1 Sep 2015 12:12:44 +0200 Message-Id: <1441102364-32516-3-git-send-email-helmut.schaa@googlemail.com> (sfid-20150901_121459_008022_BD1777A0) In-Reply-To: <1441102364-32516-1-git-send-email-helmut.schaa@googlemail.com> References: <1441102364-32516-1-git-send-email-helmut.schaa@googlemail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: When debugging wireless powersave issues on the AP side it's quite helpful to see our own beacons that are transmitted by the hardware/driver. However, this is not that easy since beacons don't pass through the regular TX queues. Preferably drivers would call ieee80211_tx_status also for tx'ed beacons but that's not always possible. Hence, just send a copy of each beacon generated by ieee80211_beacon_get_tim to monitor devices when they are getting fetched by the driver. --- net/mac80211/tx.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c index 84e0e8c..f522579 100644 --- a/net/mac80211/tx.c +++ b/net/mac80211/tx.c @@ -3512,6 +3512,9 @@ struct sk_buff *ieee80211_beacon_get_tim(struct ieee80211_hw *hw, { struct ieee80211_mutable_offsets offs = {}; struct sk_buff *bcn = __ieee80211_beacon_get(hw, vif, &offs, false); + struct sk_buff *copy; + struct ieee80211_supported_band *sband; + int shift; if (tim_offset) *tim_offset = offs.tim_offset; @@ -3519,6 +3522,13 @@ struct sk_buff *ieee80211_beacon_get_tim(struct ieee80211_hw *hw, if (tim_length) *tim_length = offs.tim_length; + /* send a copy to monitor interfaces */ + if (hw_to_local(hw)->monitors && (copy = skb_copy(bcn, GFP_ATOMIC))) { + shift = ieee80211_vif_get_shift(vif); + sband = hw->wiphy->bands[ieee80211_get_sdata_band(vif_to_sdata(vif))]; + ieee80211_tx_monitor(hw_to_local(hw), copy, sband, 1, shift, true); + } + return bcn; } EXPORT_SYMBOL(ieee80211_beacon_get_tim); -- 1.8.4.5