Return-path: Received: from mail-io0-f181.google.com ([209.85.223.181]:36856 "EHLO mail-io0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752476AbbIAOaY (ORCPT ); Tue, 1 Sep 2015 10:30:24 -0400 Received: by ioii196 with SMTP id i196so2808354ioi.3 for ; Tue, 01 Sep 2015 07:30:23 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <55E5B065.8050107@openwrt.org> References: <1441102364-32516-1-git-send-email-helmut.schaa@googlemail.com> <1441102364-32516-3-git-send-email-helmut.schaa@googlemail.com> <55E5B065.8050107@openwrt.org> Date: Tue, 1 Sep 2015 16:30:22 +0200 Message-ID: (sfid-20150901_163027_205046_54ABC3A9) Subject: Re: [RFC 2/2] mac80211: Copy tx'ed beacons to monitor mode From: Helmut Schaa To: Felix Fietkau Cc: linux-wireless , Johannes Berg Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Sep 1, 2015 at 4:04 PM, Felix Fietkau wrote: > On 2015-09-01 12:12, Helmut Schaa wrote: >> When debugging wireless powersave issues on the AP side it's quite helpful >> to see our own beacons that are transmitted by the hardware/driver. However, >> this is not that easy since beacons don't pass through the regular TX queues. >> >> Preferably drivers would call ieee80211_tx_status also for tx'ed beacons >> but that's not always possible. Hence, just send a copy of each beacon >> generated by ieee80211_beacon_get_tim to monitor devices when they are >> getting fetched by the driver. > How about also adding a hw flag to allow drivers to indicate that they > submit tx status for beacons. Makes sense, yes. Waiting for other comments before resending ... Helmut