Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:60065 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932679AbbI3Ser (ORCPT ); Wed, 30 Sep 2015 14:34:47 -0400 Subject: Re: Can we ignore frames with invalid BSSID in IBSS mode? To: Johannes Berg , "linux-wireless@vger.kernel.org" , ath10k References: <5605D228.7050609@candelatech.com> (sfid-20150926_010105_789618_F93D668E) <1443595615.1859.2.camel@sipsolutions.net> <560BFABC.8090504@candelatech.com> <1443626224.1859.9.camel@sipsolutions.net> <560C036C.7000401@candelatech.com> <1443633267.1859.11.camel@sipsolutions.net> <560C19F3.6070903@candelatech.com> <1443637830.1859.17.camel@sipsolutions.net> From: Ben Greear Message-ID: <560C2B46.2040200@candelatech.com> (sfid-20150930_203451_159035_95F50957) Date: Wed, 30 Sep 2015 11:34:46 -0700 MIME-Version: 1.0 In-Reply-To: <1443637830.1859.17.camel@sipsolutions.net> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/30/2015 11:30 AM, Johannes Berg wrote: > On Wed, 2015-09-30 at 10:20 -0700, Ben Greear wrote: >> >> Yes, it is a transmitter side problem, and A-MSDU on IBSS >> is disabled by default in all ath10k firmware versions that I am aware of. > > Right. > >> I was hoping there might be a way to allow A-MSDU + IBSS + ath10k >> to work in future kernels without applying out-of-tree >> kernel hacks. This would let people with appropriate firmware >> enable IBSS + A-MSDU for added performance in cases where they >> knew the peer could support the needed work-around. >> >> I don't think it is worth a lot of effort, but if it were relatively >> simple to fix, then maybe it is worth it. >> > > Had it been a receiver-side issue, then it'd seem reasonable to work > around it. But it being a transmitter-side issue it doesn't really seem > so - *every* possible peer would have to be adjusted, and some might > not even be able to get adjusted (e.g. devices that have A-MSDU > deaggregation in hardware/firmware) ... > > So to do that properly you'd have to advertise some sort of quirk > vendor IE, and all that, which seems excessive given the limited use. I was figuring the main users of this would be people rolling out IBSS mesh networks and such, and they might have good knowledge of exactly what peers will be used. It is a small enough hack to the stack to just ignore the BSSID for adhoc, and since CT firmware related patches are not accepted upstream anyway, I guess anyone doing this is likely running custom patches already. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com