Return-path: Received: from mail-ob0-f179.google.com ([209.85.214.179]:33044 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751138AbbIFRJi (ORCPT ); Sun, 6 Sep 2015 13:09:38 -0400 Received: by obbbh8 with SMTP id bh8so48409456obb.0 for ; Sun, 06 Sep 2015 10:09:37 -0700 (PDT) Subject: Re: [PATCH] Add new mac80211 driver mwlwifi. To: Kalle Valo , Arend van Spriel References: <6d9f23a4a8bf4315b0c7630a9a1c37ad@SC-EXCH02.marvell.com> <1433598191.2467.65.camel@sipsolutions.net> <877fo3he8y.fsf@kamboji.qca.qualcomm.com> <55EC6453.3000601@broadcom.com> <87pp1vfqbh.fsf@kamboji.qca.qualcomm.com> Cc: Johannes Berg , David Lin , "linux-wireless@vger.kernel.org" , Pete Hsieh , Chor Teck Law From: Larry Finger Message-ID: <55EC734F.90307@lwfinger.net> (sfid-20150906_190940_900748_2F8D807E) Date: Sun, 6 Sep 2015 12:09:35 -0500 MIME-Version: 1.0 In-Reply-To: <87pp1vfqbh.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/06/2015 11:46 AM, Kalle Valo wrote: > Arend van Spriel writes: > >> On 09/06/2015 03:24 PM, Kalle Valo wrote: >>> Johannes Berg writes: >>> >>>> On Thu, 2015-06-04 at 04:57 +0000, David Lin wrote: >>>> >>>>> drivers/net/wireless/mwlwifi/Kconfig | 17 + >>>> >>>> Does this driver has any relation to mwifiex? Perhaps the same >>>> maintainer team, etc.? Could consider moving all the Marvell drivers >>>> into one directory, but not really necessary I guess. >>> >>> Actually I would want to start adding vendor directories for wireless >>> drivers, just like drivers/net/ethernet has, to cleanup the directory >>> structure. So for example this driver we would have >>> drivers/net/wireless/marvell/mwlwifi and later we would start moving >>> existing drivers to vendor drivers as well. Thoughts? >> >> Right now our umbrella folder is brcm80211. I am fine changing it to >> broadcom if explicit vendor names are preferred although brcm80211 >> still has my personal preference. > > In your case I was actually thinking of moving it to broadcom/brcm80211. > And then we would also have broadcom/b43 and broadcom/b43legacy. So the > only change is addition of a new directory. How does that sound? As the maintainer of b43legacy, I think that change is good. I will need to retrain my muscle memory to get the right directory when I'm typing, but that will come. Larry