Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:7312 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbbISJn2 (ORCPT ); Sat, 19 Sep 2015 05:43:28 -0400 Message-ID: <55FD2E3E.4020804@broadcom.com> (sfid-20150919_114331_037954_F156B168) Date: Sat, 19 Sep 2015 11:43:26 +0200 From: Arend van Spriel MIME-Version: 1.0 To: Kalle Valo CC: linux-wireless , Hante Meuleman Subject: Re: [PATCH 01/16] brcmfmac: Fix exception handling. References: <1442606899-31872-1-git-send-email-arend@broadcom.com> <1442606899-31872-2-git-send-email-arend@broadcom.com> In-Reply-To: <1442606899-31872-2-git-send-email-arend@broadcom.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/18/2015 10:08 PM, Arend van Spriel wrote: > From: Hante Meuleman > > In some exception situations the ifp->vif was not properly assigned > which could result in crash. Tested-by: Rafał Miłecki > Reviewed-by: Arend Van Spriel > Reviewed-by: Pieter-Paul Giesberts > Signed-off-by: Hante Meuleman > Signed-off-by: Arend van Spriel > --- > drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c > index 600098d..da24bf0 100644 > --- a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c > +++ b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c > @@ -6332,6 +6332,7 @@ wiphy_unreg_out: > priv_out: > wl_deinit_priv(cfg); > brcmf_free_vif(vif); > + ifp->vif = NULL; > wiphy_out: > brcmf_free_wiphy(wiphy); > return NULL; >