Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:33550 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751359AbbJYI02 (ORCPT ); Sun, 25 Oct 2015 04:26:28 -0400 Date: Sat, 24 Oct 2015 18:29:44 -0700 From: Greg KH To: Glen Lee Cc: devel@driverdev.osuosl.org, austin.shin@atmel.com, linux-wireless@vger.kernel.org, Nicolas.FERRE@atmel.com, adel.noureldin@atmel.com, tony.cho@atmel.com, leo.kim@atmel.com, adham.abozaeid@atmel.com Subject: Re: [PATCH 02/28] staging: wicl1000: isr_uh_routine: use netdev private wilc Message-ID: <20151025012944.GA22184@kroah.com> (sfid-20151025_092636_706660_4AB4845A) References: <1445578124-31486-1-git-send-email-glen.lee@atmel.com> <1445578124-31486-2-git-send-email-glen.lee@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1445578124-31486-2-git-send-email-glen.lee@atmel.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote: > Use netdev private member wilc instead of g_linux_wlan and Change argument wilc > with dev in the function request_threaded_irq to pass back to handler > the function isr_uh_routine. > > Signed-off-by: Glen Lee > --- > drivers/staging/wilc1000/linux_wlan.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c > index b036b96..7b0614d 100644 > --- a/drivers/staging/wilc1000/linux_wlan.c > +++ b/drivers/staging/wilc1000/linux_wlan.c > @@ -229,10 +229,15 @@ static int dev_state_ev_handler(struct notifier_block *this, unsigned long event > #if (defined WILC_SPI) || (defined WILC_SDIO_IRQ_GPIO) > static irqreturn_t isr_uh_routine(int irq, void *user_data) > { > + perInterface_wlan_t *nic; > + struct wilc *wl; > + > + nic = netdev_priv(usedata); This patch breaks the build, which means you didn't even test build the series :( Please redo this whole series and test your patches better. greg k-h