Subject: Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret
 returning 0
To: Punit Vara <punitvara@gmail.com>, jirislaby@gmail.com
References: <1445538363-2893-1-git-send-email-punitvara@gmail.com>
Cc: mickflemm@gmail.com, mcgrof@do-not-panic.com, kvalo@codeaurora.org,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <56292C55.4030706@cogentembedded.com> (sfid-20151022_203536_354271_99C5ADDB)
Date: Thu, 22 Oct 2015 21:35:01 +0300
MIME-Version: 1.0
In-Reply-To: <1445538363-2893-1-git-send-email-punitvara@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Sender: linux-wireless-owner@vger.kernel.org

Hello.

On 10/22/2015 09:26 PM, Punit Vara wrote:

> This patch is to the ath5k/eeprom.c that fixes up warning caught by
> coccicheck:
>
> -Unneeded variable: "ret". Return "0" on line 1733
>
> Remove unneccesary variable ret created to return zero.
>
> Also removed empty line suggested by Sergei
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
>   drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/eeprom.c b/drivers/net/wireless/ath/ath5k/eeprom.c
> index 94d34ee..0c82ea5 100644
> --- a/drivers/net/wireless/ath/ath5k/eeprom.c
> +++ b/drivers/net/wireless/ath/ath5k/eeprom.c
> @@ -1707,8 +1707,7 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah)
>   	struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom;
>   	u32 offset;
>   	u16 val;
> -	int ret = 0, i;
> -

    No, this one shouldn't have been removed. There should an empty line 
between the declarations and the statements.

> +	int i;
>   	offset = AR5K_EEPROM_CTL(ee->ee_version) +
>   				AR5K_EEPROM_N_CTLS(ee->ee_version);
>

MBR, Sergei