Return-path: Received: from eusmtp01.atmel.com ([212.144.249.242]:23393 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752267AbbJZCFv (ORCPT ); Sun, 25 Oct 2015 22:05:51 -0400 Message-ID: <562D8B2B.2000308@atmel.com> (sfid-20151026_030618_588418_910CC368) Date: Mon, 26 Oct 2015 11:08:43 +0900 From: glen lee MIME-Version: 1.0 To: Greg KH CC: , , , , , , , Subject: Re: [PATCH 02/28] staging: wicl1000: isr_uh_routine: use netdev private wilc References: <1445578124-31486-1-git-send-email-glen.lee@atmel.com> <1445578124-31486-2-git-send-email-glen.lee@atmel.com> <20151025012944.GA22184@kroah.com> In-Reply-To: <20151025012944.GA22184@kroah.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2015년 10월 25일 10:29, Greg KH wrote: > On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote: >> Use netdev private member wilc instead of g_linux_wlan and Change argument wilc >> with dev in the function request_threaded_irq to pass back to handler >> the function isr_uh_routine. >> >> Signed-off-by: Glen Lee >> --- >> drivers/staging/wilc1000/linux_wlan.c | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c >> index b036b96..7b0614d 100644 >> --- a/drivers/staging/wilc1000/linux_wlan.c >> +++ b/drivers/staging/wilc1000/linux_wlan.c >> @@ -229,10 +229,15 @@ static int dev_state_ev_handler(struct notifier_block *this, unsigned long event >> #if (defined WILC_SPI) || (defined WILC_SDIO_IRQ_GPIO) >> static irqreturn_t isr_uh_routine(int irq, void *user_data) >> { >> + perInterface_wlan_t *nic; >> + struct wilc *wl; >> + >> + nic = netdev_priv(usedata); > This patch breaks the build, which means you didn't even test build the > series :( Hi greg, I built every patches I'v posted and also there is no build error for this patch. Would you please reconsider this patch again? > Please redo this whole series and test your patches better. > > greg k-h