Return-path: Received: from mail-lb0-f176.google.com ([209.85.217.176]:35082 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965628AbbJ1NfQ (ORCPT ); Wed, 28 Oct 2015 09:35:16 -0400 Received: by lbbes7 with SMTP id es7so5732992lbb.2 for ; Wed, 28 Oct 2015 06:35:14 -0700 (PDT) Subject: Re: [RESEND PATCH 07/10] net: wireless: iwlegacy: Remove unneeded variable ret To: Punit Vara , kvalo@qca.qualcomm.com References: <1445972565-14963-1-git-send-email-punitvara@gmail.com> <1445972565-14963-7-git-send-email-punitvara@gmail.com> Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <5630CF11.8080504@cogentembedded.com> (sfid-20151028_143535_064161_62D6E610) Date: Wed, 28 Oct 2015 16:35:13 +0300 MIME-Version: 1.0 In-Reply-To: <1445972565-14963-7-git-send-email-punitvara@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hello. On 10/27/2015 10:02 PM, Punit Vara wrote: > This patch is to the 3945-mac.c file that fixes up following warning > by coccicheck: > > drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: > "ret". Return "- EOPNOTSUPP" on line 249 > > Return -EOPNOTSUPP directly instead of return using ret > > Signed-off-by: Punit Vara > --- > drivers/net/wireless/iwlegacy/3945-mac.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c b/drivers/net/wireless/iwlegacy/3945-mac.c > index af1b3e6..ff4dc44 100644 > --- a/drivers/net/wireless/iwlegacy/3945-mac.c > +++ b/drivers/net/wireless/iwlegacy/3945-mac.c > @@ -244,9 +244,7 @@ il3945_set_dynamic_key(struct il_priv *il, struct ieee80211_key_conf *keyconf, > static int > il3945_remove_static_key(struct il_priv *il) > { > - int ret = -EOPNOTSUPP; > - > - return ret; > + return -EOPNOTSUPP; > } > > static int > @@ -529,7 +527,6 @@ il3945_tx_skb(struct il_priv *il, > if (unlikely(tid >= MAX_TID_COUNT)) > goto drop; > } > - Unrelated white space change. MBR, Sergei