Date: Thu, 19 Nov 2015 07:45:51 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: glen lee <glen.lee@atmel.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	devel@driverdev.osuosl.org, austin.shin@atmel.com,
	linux-wireless@vger.kernel.org, Nicolas.FERRE@atmel.com,
	adel.noureldin@atmel.com, tony.cho@atmel.com, leo.kim@atmel.com,
	adham.abozaeid@atmel.com
Subject: Re: [PATCH 3/4] staging: wilc1000: rename index to
 tcp_pending_ack_idx
Message-ID: <20151119154551.GB7601@kroah.com> (sfid-20151119_164556_197567_8730F608)
References: <1447898761-6938-1-git-send-email-glen.lee@atmel.com>
 <1447898761-6938-3-git-send-email-glen.lee@atmel.com>
 <20151119062343.GR18797@mwanda>
 <564D71EE.20704@atmel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
In-Reply-To: <564D71EE.20704@atmel.com>
Sender: linux-wireless-owner@vger.kernel.org

On Thu, Nov 19, 2015 at 03:53:34PM +0900, glen lee wrote:
> 
> 
> On 2015년 11월 19일 15:23, Dan Carpenter wrote:
> >On Thu, Nov 19, 2015 at 11:06:00AM +0900, Glen Lee wrote:
> >>This patch renames "index" of struct txq_entry_t to tcp_pending_ack_idx since
> >>this name could be confused index of txq_entry_t. It is index of tcp pending
> >>ack.
> >>
> >>It fixes 8e55639d066f4ef402ba88fca08ed1be70e1c4da
> >>
> >It is just a cleanup patch and not a bugfix patch so "fix" is the wrong
> >word here.  But the correct format for fixes tags is:
> >
> >Fixes: 123456789012 ('Title of patch')
> 
> I see, I learned another one. Thanks.

Git can do this automatically for you:
	 git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"
I have an alias for this to make it easier to use frequently.

greg k-h