Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]:25660 "EHLO sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753257AbbK3IsU (ORCPT ); Mon, 30 Nov 2015 03:48:20 -0500 From: Kalle Valo To: Brent Taylor CC: , , , Subject: Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree References: <1444972259-24260-1-git-send-email-motobud@gmail.com> <1448774038-26984-1-git-send-email-motobud@gmail.com> Date: Mon, 30 Nov 2015 10:48:03 +0200 In-Reply-To: <1448774038-26984-1-git-send-email-motobud@gmail.com> (Brent Taylor's message of "Sat, 28 Nov 2015 23:13:58 -0600") Message-ID: <87zixvlvp8.fsf@kamboji.qca.qualcomm.com> (sfid-20151130_094837_354472_E30C4F31) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Brent Taylor writes: > Signed-off-by: Brent Taylor > > ath6kl: Use vmalloc for loading firmware using api1 method and free using kvfree > --- > Changes v1 -> v2: > - simplify memory allocation > - use kvfree Why? The commit log should _always_ answer that. Are you fixing a bug (what bug exactly?), is this just cleanup or what? And the commit log is wrongly formatted anyway, the Signed-off-by line should be the last and there should be no "ath6kl:" string in the commit log (just in the title). Use 'git log' to find examples. -- Kalle Valo