Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:35594 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754720AbbKYJQa (ORCPT ); Wed, 25 Nov 2015 04:16:30 -0500 From: Kalle Valo To: Nick Kossifidis Cc: "Pan\, Miaoqing" , Stephan Mueller , "Sepehrdad\, Pouyan" , "Jacobson\, David" , Oleksij Rempel , "linville\@tuxdriver.com" , "linux-wireless\@vger.kernel.org" , "Theodore Ts'o" , "linux-crypto\@vger.kernel.org" , "nhorman\@tuxdriver.com" Subject: Re: [PATCH 2/2] ath9k: export HW random number generator References: <1436946847-10909-1-git-send-email-miaoqing@qca.qualcomm.com> <55B60BC9.8040800@rempel-privat.de> <3945775.m5HblJPgiO@tauon.atsec.com> <8738043ith.fsf@kamboji.qca.qualcomm.com> <3ec13417acdc48628adaedb68d259b9c@NASANEXM01E.na.qualcomm.com> Date: Wed, 25 Nov 2015 11:16:22 +0200 In-Reply-To: (Nick Kossifidis's message of "Sat, 7 Nov 2015 17:39:21 -0600") Message-ID: <87io4qphg9.fsf@kamboji.qca.qualcomm.com> (sfid-20151125_101637_254144_4C3605B3) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Nick Kossifidis writes: > That was partially my intention too when I submitted > 2aa56cca3571fd08c0c38f3e2d4bb0bfb3def3c5 which mixes FFT measurements > to the entropy pool without providing any estimation on entropy > (entropy estimation is the wrong approach, read the papers on fortuna > for more information on that). I believe that this approach is better > than mine because FFT data is too much (high throughput) and may have > a negative impact on the pool when mixed like this (even without the > entropy count) so Kale please revert my patch also (I was about to > submit a request for reverting it and writing something similar when > this thread came up). Could you submit the revert as a patch and with the explonation in the commit log, please? -- Kalle Valo