Return-path: Received: from eusmtp01.atmel.com ([212.144.249.242]:10183 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755298AbbKYC4v (ORCPT ); Tue, 24 Nov 2015 21:56:51 -0500 From: Glen Lee To: CC: , , , , , , , , Subject: [PATCH 05/10] staging: wilc1000: fixes potential null dereference 'wid.val' Date: Wed, 25 Nov 2015 11:59:44 +0900 Message-ID: <1448420389-4192-5-git-send-email-glen.lee@atmel.com> (sfid-20151125_035653_484484_E00A76C0) In-Reply-To: <1448420389-4192-1-git-send-email-glen.lee@atmel.com> References: <1448420389-4192-1-git-send-email-glen.lee@atmel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: From: Leo Kim This patch fixes the error reported by smatch. - Handle_ListenStateExpired() error: potential null dereference 'wid.val' If kmalloc failed, referenced to a NULL pointer. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index aae5a03..da4f4c6 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -2629,8 +2629,10 @@ static u32 Handle_ListenStateExpired(struct host_if_drv *hif_drv, wid.size = 2; wid.val = kmalloc(wid.size, GFP_KERNEL); - if (!wid.val) + if (!wid.val) { PRINT_ER("Failed to allocate memory\n"); + return -ENOMEM; + } wid.val[0] = u8remain_on_chan_flag; wid.val[1] = FALSE_FRMWR_CHANNEL; -- 1.9.1