MIME-Version: 1.0
In-Reply-To: <CABXAfNJZSgy+2v1VH8LVhYTtjsgKGmY3u7eyu8mUfYMezRcFPQ@mail.gmail.com>
References: <1446847163-9643-1-git-send-email-punitvara@gmail.com>
	<CABXAfNJZSgy+2v1VH8LVhYTtjsgKGmY3u7eyu8mUfYMezRcFPQ@mail.gmail.com>
Date: Sat, 7 Nov 2015 03:47:57 +0530
Message-ID: <CABXAfNJJnvYSkU7FsfDgsUMxTs_fP+y3Ebay8nwAsx9PD0Bnrg@mail.gmail.com> (sfid-20151106_231822_802886_D4CAEFBD)
Subject: Re: [PATCH] Staging: wilc1000: Declare *wilc in init_wilc_driver to
 fix build error
From: punit vara <punitvara@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: glen.lee@atmel.com, linux-wireless@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Punit Vara <punitvara@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-wireless-owner@vger.kernel.org

On Sat, Nov 7, 2015 at 3:39 AM, punit vara <punitvara@gmail.com> wrote:
> On Sat, Nov 7, 2015 at 3:29 AM, Punit Vara <punitvara@gmail.com> wrote:
>> This patch is to the linux_wlan.c file that fixes declaration of *wilc
>> to remove following error while building it.
>>
>> make drivers/staging/wilc1000/linux_wlan.o
>> drivers/staging/wilc1000/linux_wlan.c:1824:24: error: ‘wilc’ undeclared
>>
>> Signed-off-by: Punit Vara <punitvara@gmail.com>
>> ---
>>  drivers/staging/wilc1000/linux_wlan.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
>> index 2a5b36f..0805050 100644
>> --- a/drivers/staging/wilc1000/linux_wlan.c
>> +++ b/drivers/staging/wilc1000/linux_wlan.c
>> @@ -1780,6 +1780,7 @@ int wilc_netdev_init(struct wilc **wilc)
>>  /*The 1st function called after module inserted*/
>>  static int __init init_wilc_driver(void)
>>  {
>> +       struct wilc *wilc;
>>  #ifdef WILC_SPI
>>         struct wilc *wilc;
>>  #endif
>> --
>> 2.6.2
>>
> drivers/staging/wilc1000/linux_wlan.c: In function ‘wilc1000_wlan_init’:
> drivers/staging/wilc1000/linux_wlan.c:1109:3: error: implicit
> declaration of function ‘init_irq’
> [-Werror=implicit-function-declaration]
>    if (init_irq(dev)) {
>    ^
> drivers/staging/wilc1000/linux_wlan.c: In function ‘init_wilc_driver’:
> drivers/staging/wilc1000/linux_wlan.c:1824:24: error: ‘wilc’
> undeclared (first use in this function)
>   if (wilc_netdev_init(&wilc))
>                         ^
> drivers/staging/wilc1000/linux_wlan.c:1824:24: note: each undeclared
> identifier is reported only once for each function it appears in
> cc1: some warnings being treated as errors
> scripts/Makefile.build:258: recipe for target
> 'drivers/staging/wilc1000/linux_wlan.o' failed
> make[1]: *** [drivers/staging/wilc1000/linux_wlan.o] Error 1
> Makefile:1526: recipe for target 'drivers/staging/wilc1000/linux_wlan.o' failed
> make: *** [drivers/staging/wilc1000/linux_wlan.o] Error 2
>
> There were two errors generated by make drivers/staging/wilc1000/linux_wlan.o
> One error I have removed second one I will resolve tomorrow. Should I
> remove function init_irq defination from #ifdef ? or any better
> solution to remove this error?

Today I have fetched greg staging tree I have found

make drivers/staging/wilc1000/linux_wlan.o

build failed.

So I am just trying to fix it . I removed one error and send patch to
get some feedback about second error. I will be sending whole patch
fixing both errors.