Return-path: Received: from mail-vk0-f51.google.com ([209.85.213.51]:34999 "EHLO mail-vk0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932665AbbLHP4A (ORCPT ); Tue, 8 Dec 2015 10:56:00 -0500 Received: by vkha189 with SMTP id a189so17030955vkh.2 for ; Tue, 08 Dec 2015 07:55:59 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1449590039.4154.12.camel@sipsolutions.net> References: <1449583479-26658-1-git-send-email-emmanuel.grumbach@intel.com> <1449583479-26658-7-git-send-email-emmanuel.grumbach@intel.com> <1449589374.4154.11.camel@sipsolutions.net> <1449590039.4154.12.camel@sipsolutions.net> From: Krishna Chaitanya Date: Tue, 8 Dec 2015 21:25:40 +0530 Message-ID: (sfid-20151208_165604_920337_E2088D2A) Subject: Re: [PATCH 6/9] mac80211: handle width changes from opmode notification IE in beacon To: Johannes Berg Cc: Emmanuel Grumbach , linux-wireless , Eyal Shapira , Eyal Shapira Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Dec 8, 2015 at 9:23 PM, Johannes Berg wrote: > On Tue, 2015-12-08 at 21:17 +0530, Krishna Chaitanya wrote: >> >> > If the rate control algorithm doesn't look at sta->sta.rx_nss then >> > that's their bug. >> >> Yes, it looks like it. Only BW is handled, not the NSS change, and >> without this patch OP MODE IE in beacon updates neither NSS nor BW. >> >> For Action frame OP MODE IE, NSS will be updated. Typo BW will be updated. > > I don't see how that would happen - they end up in exactly the same > code path. As nss_only is false, BW will be update in case of action frame.