Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]:22846 "EHLO sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752864AbbLVJMb (ORCPT ); Tue, 22 Dec 2015 04:12:31 -0500 From: Kalle Valo To: Souptick Joarder CC: Brent Taylor , , , linux-wireless , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method References: <1448948470-31111-1-git-send-email-motobud@gmail.com> Date: Tue, 22 Dec 2015 11:12:16 +0200 In-Reply-To: (Souptick Joarder's message of "Tue, 22 Dec 2015 14:35:20 +0530") Message-ID: <87poxy7spb.fsf@kamboji.qca.qualcomm.com> (sfid-20151222_101344_001420_D5392111) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Souptick Joarder writes: > Hi Brent, > > On Tue, Dec 22, 2015 at 3:23 AM, Brent Taylor wrote: >> On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder wrote: >>> Hi Brent, >>> >>> On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor wrote: >>> >>>> --- a/drivers/net/wireless/ath/ath6kl/init.c >>>> +++ b/drivers/net/wireless/ath/ath6kl/init.c >>>> @@ -673,10 +673,15 @@ static int ath6kl_get_fw(struct ath6kl *ar, const char *filename, >>>> return ret; >>>> >>>> *fw_len = fw_entry->size; >>>> - *fw = kmemdup(fw_entry->data, fw_entry->size, GFP_KERNEL); >>>> + if (&ar->fw == fw) >>>> + *fw = vmalloc(fw_entry->size); >>>> + else >>>> + *fw = kmalloc(fw_entry->size, GFP_KERNEL) >>> >>> Why vmalloc and kmalloc both are required? can't use either >>> vmalloc or kmalloc? >> >> My original problem was that kmemdup (which uses kmalloc) could not >> allocate enough memory > > If kmemdump ( which uses kmalloc) could not allocate memory then > using kmalloc again can lead to same problem. > I guess it will be correct to use > *fw = vmalloc(fw_entry->size); > Correct me if i am wrong. That sounds best. But remember take into account DMA requirements, IIRC you cannot DMA from vmalloc memory on all platforms. -- Kalle Valo