Return-path: Received: from mail-wm0-f44.google.com ([74.125.82.44]:34711 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbbLJKYo (ORCPT ); Thu, 10 Dec 2015 05:24:44 -0500 Received: by mail-wm0-f44.google.com with SMTP id v187so25556504wmv.1 for ; Thu, 10 Dec 2015 02:24:44 -0800 (PST) Subject: Re: [PATCH 01/13] brcmfmac: Simplify scan timing configuration. To: Kalle Valo , Arend van Spriel References: <1449656572-16158-1-git-send-email-arend@broadcom.com> <1449656572-16158-2-git-send-email-arend@broadcom.com> <87zixj93gg.fsf@kamboji.qca.qualcomm.com> Cc: linux-wireless , Hante Meuleman From: Arend van Spriel Message-ID: <566952EA.4070107@gmail.com> (sfid-20151210_112449_613239_320571D8) Date: Thu, 10 Dec 2015 11:24:42 +0100 MIME-Version: 1.0 In-Reply-To: <87zixj93gg.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09-12-15 14:06, Kalle Valo wrote: > Arend van Spriel writes: > >> From: Hante Meuleman >> > > Please, no empty commit logs. For a patch like this it takes like 30 > seconds to write a short log describing why and how you are simplifying > the code. Next year I'm thinking of start rejecting patches without a > commit log. Time to consider new year resolutions, heh ;-) Anyway, it is noted and will see if I can gatekeep this better. > This is a minor nitpick but it's not that common to the commit title > with a period. Have to agree to the nitpicking part :-p Can keep it in mind though. >> Reviewed-by: Arend Van Spriel >> Reviewed-by: Pieter-Paul Giesberts >> Signed-off-by: Hante Meuleman >> Change-Id: Ie179527eb29f2ed8b7869dac24591e2513775393 >> Reviewed-on: http://hnd-swgit.sj.broadcom.com:8080/5445 >> Reviewed-by: brcm80211 ci >> Signed-off-by: Arend van Spriel > > Forgot to clean the tags? :) *sigh* Obviously. Should not try to multitask when preparing patch series. Gr. AvS