Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:59246 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753600AbbLCU3Y (ORCPT ); Thu, 3 Dec 2015 15:29:24 -0500 Subject: Re: Can we increase IEEE80211_MAX_QUEUES To: Johannes Berg , "linux-wireless@vger.kernel.org" References: <5660A31E.3010507@candelatech.com> <1449174081.31265.3.camel@sipsolutions.net> From: Ben Greear Message-ID: <5660A623.1040002@candelatech.com> (sfid-20151203_212927_458662_22D4DFD1) Date: Thu, 3 Dec 2015 12:29:23 -0800 MIME-Version: 1.0 In-Reply-To: <1449174081.31265.3.camel@sipsolutions.net> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 12/03/2015 12:21 PM, Johannes Berg wrote: > On Thu, 2015-12-03 at 12:16 -0800, Ben Greear wrote: >> ath10k wants to use vdev-id as a queue-id, and I want to support up >> to >> 64 vdevs. In the 4.2 kernel, this is causing splats when using lots >> of >> vdevs because then queue is out of range. >> >> Can we just increase IEEE80211_MAX_QUEUES to 64? >> > > I think not, that would likely cause a lot of data structures to grow > too much. We'd have to do more dynamic things in that case, I suppose. > > Does the original premise even make sense though? A single queue for > each vdev seems a bit strange. I think it is all fakery in the driver, but I'm not sure how easy it would be to fix. I'm not certain why I'm suddenly seeing this, but I just started using 4.2 kernel again and maybe that is the difference. I also tweaked firmware recently... I'll make a stab at allowing 64 queues, and also try to figure out why I started seeing the problem. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com