Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:42128 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257AbcAZVc0 (ORCPT ); Tue, 26 Jan 2016 16:32:26 -0500 Message-ID: <1453843943.2759.79.camel@sipsolutions.net> (sfid-20160126_223229_218048_FE4ECDA3) Subject: Re: [PATCH 1/2] mac80211: Remove connected MPP table entries with MPath From: Johannes Berg To: Bob Copeland Cc: Henning Rogge , linux-wireless@vger.kernel.org, "David S. Miller" , Henning Rogge Date: Tue, 26 Jan 2016 22:32:23 +0100 In-Reply-To: <1453843889.2759.78.camel@sipsolutions.net> (sfid-20160126_223138_180246_395DC461) References: <1453190672-9748-1-git-send-email-henning.rogge@fkie.fraunhofer.de> <1453190672-9748-2-git-send-email-henning.rogge@fkie.fraunhofer.de> <1453808485.2759.32.camel@sipsolutions.net> <20160126183628.GA30183@localhost> <1453841613.2759.77.camel@sipsolutions.net> <20160126212221.GA5710@localhost> (sfid-20160126_222227_889414_A397F9B9) <1453843889.2759.78.camel@sipsolutions.net> (sfid-20160126_223138_180246_395DC461) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2016-01-26 at 22:31 +0100, Johannes Berg wrote: > On Tue, 2016-01-26 at 16:22 -0500, Bob Copeland wrote: > >   > > void mesh_path_flush_by_nexthop(struct sta_info *sta) > > { > >     [...] > > rhashtable_walk_start(&iter); > > It seems you need to check the return value here? > Actually, maybe not. Not sure I understand the return to beginning though. johannes