Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:35902 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759002AbcAUNvN (ORCPT ); Thu, 21 Jan 2016 08:51:13 -0500 Date: Thu, 21 Jan 2016 14:51:10 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Kalle Valo Cc: Pavel Machek , Arend van Spriel , Ivaylo Dimitrov , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Gnedt Subject: Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration Message-ID: <20160121135110.GH7192@pali> (sfid-20160121_145116_365515_EA30CBDC) References: <1451130310-16666-1-git-send-email-pali.rohar@gmail.com> <5696D08F.9030906@broadcom.com> <20160114091654.GA15380@amd> <20160121085331.GO7192@pali> <87d1svyrfl.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <87d1svyrfl.fsf@kamboji.qca.qualcomm.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thursday 21 January 2016 15:48:14 Kalle Valo wrote: > Pali Rohár writes: > > > On Thursday 14 January 2016 10:16:54 Pavel Machek wrote: > >> On Wed 2016-01-13 23:32:47, Arend van Spriel wrote: > >> > On 12/26/2015 12:45 PM, Pali Rohár wrote: > >> > >Port the bt_coex_mode sysfs interface from wl1251 driver version included > >> > >in the Maemo Fremantle kernel to allow bt-coexistence mode configuration. > >> > >This enables userspace applications to set one of the modes > >> > >WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO. > >> > >The default mode is WL1251_BT_COEX_OFF. > >> > >It should be noted that this driver always enabled bt-coexistence before > >> > >and enabled bt-coexistence directly affects the receiving performance, > >> > >rendering it unusable in some low-signal situations. Especially monitor > >> > >mode is affected very badly with bt-coexistence enabled. > >> > > >> > So what user-space process will be using this interface. Did you consider > >> > adding debugfs interface? In case of monitor mode you could consider > >> > disabling bt-coex from within the driver itself. > >> > >> This aint no debugging feature. > > > > Right, bt-coex is not for debugging purpose, but for normal usage, when > > user want to use together bluetooth and wifi or just one of those. > > I think most of other drivers have a debugfs interface for btcoex, I > guess mostly for testing purposes. But this really should be added to > cfg80211. All other TI wireless drivers have "bt_coex_state" sysfs node. -- Pali Rohár pali.rohar@gmail.com