Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:36542 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933042AbcAST1w (ORCPT ); Tue, 19 Jan 2016 14:27:52 -0500 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Subject: Re: brcmfmac: fix sdio sg table alloc crash From: Kalle Valo In-Reply-To: <1453203564-15974-1-git-send-email-arend@broadcom.com> To: Arend van Spriel Cc: linux-wireless , Hante Meuleman , Arend van Spriel Message-Id: <20160119192751.CFFBB60266@smtp.codeaurora.org> (sfid-20160119_202756_024598_E4DEEA07) Date: Tue, 19 Jan 2016 19:27:51 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: > From: Hante Meuleman > > With commit 7d34b0560567 ("brcmfmac: Move all module parameters to > one place") a bug was introduced causing a null pointer exception. > This patch fixes the bug by initializing the sg table till after > the settings have been initialized. > > Fixes: 7d34b0560567 ("brcmfmac: Move all module parameters to one place") > Reported-by: Marc Zyngier > Tested-by: Marc Zyngier > Reviewed-by: Arend Van Spriel > Reviewed-by: Franky (Zhenhui) Lin > Reviewed-by: Pieter-Paul Giesberts > Signed-off-by: Hante Meuleman > Signed-off-by: Arend van Spriel Thanks, applied to wireless-drivers.git. Kalle Valo