Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:49098 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbcAGJXI (ORCPT ); Thu, 7 Jan 2016 04:23:08 -0500 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Subject: Re: rt2x00pci: Disable memory-write-invalidate when the driver exits From: Kalle Valo In-Reply-To: <1451894138-3482-1-git-send-email-baijiaju1990@163.com> To: Jia-Ju Bai Cc: sgruszka@redhat.com, helmut.schaa@googlemail.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Message-Id: <20160107092307.76F55605BD@smtp.codeaurora.org> (sfid-20160107_102331_011100_E864A182) Date: Thu, 7 Jan 2016 09:23:07 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: > The driver calls pci_set_mwi to enable memory-write-invalidate when it > is initialized, but does not call pci_clear_mwi when it is removed. Many > other drivers calls pci_clear_mwi when pci_set_mwi is called, such as > r8169, 8139cp and e1000. > > This patch adds pci_clear_mwi in error handling and removal procedure, > which can fix the problem. > > Signed-off-by: Jia-Ju Bai > Acked-by: Helmut Schaa Thanks, applied to wireless-drivers-next.git. Kalle Valo