Return-path: Received: from smtprelay0041.hostedemail.com ([216.40.44.41]:46695 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752260AbcA3B23 (ORCPT ); Fri, 29 Jan 2016 20:28:29 -0500 Message-ID: <1454117303.10099.84.camel@perches.com> (sfid-20160130_022849_907140_60EA17B8) Subject: Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning From: Joe Perches To: Julian Calaby , Bhaktipriya Shridhar Cc: Jes Sorensen , Larry Finger , Greg Kroah-Hartman , Alexander Kuleshov , Haneen Mohammed , Andreas Ruprecht , linux-wireless , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Date: Fri, 29 Jan 2016 17:28:23 -0800 In-Reply-To: References: <20160129172908.GA14077@Karyakshetra> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, 2016-01-30 at 10:17 +1100, Julian Calaby wrote: > On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen wrote: > > Bhaktipriya Shridhar writes: > > > This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. > > > WARNING: void function return statements are not generally useful [] > > > diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c [] > > > @@ -2657,7 +2657,6 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da) > > > > > > ??????dump_mgntframe23a(padapter, pmgntframe); > > > > > > -?????return; > > > ?} > > > > If you insist on pushing this rather unncessary change, please do it > > properly, and remove the blank line before the return statement as well. > > As Jes said, you need to remove the blank lines before the returns > too. checkpatch should have picked this up, you did run the patch > through checkpatch before you sent it, right? checkpatch doesn't pick this up. If you'd like to make it do so, you're welcome to try but it's likely a bit more complicated than it appears.