Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:41089 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119AbcASMz5 (ORCPT ); Tue, 19 Jan 2016 07:55:57 -0500 From: Kalle Valo To: Arend van Spriel Cc: linux-wireless , Hante Meuleman Subject: Re: [PATCH] brcmfmac: fix sdio sg table alloc crash References: <1453203564-15974-1-git-send-email-arend@broadcom.com> Date: Tue, 19 Jan 2016 14:55:49 +0200 In-Reply-To: <1453203564-15974-1-git-send-email-arend@broadcom.com> (Arend van Spriel's message of "Tue, 19 Jan 2016 12:39:24 +0100") Message-ID: <87egdd684q.fsf@kamboji.qca.qualcomm.com> (sfid-20160119_135629_866941_7D3AB13C) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Arend van Spriel writes: > From: Hante Meuleman > > With commit 7d34b0560567 ("brcmfmac: Move all module parameters to > one place") a bug was introduced causing a null pointer exception. > This patch fixes the bug by initializing the sg table till after > the settings have been initialized. > > Reported-by: Marc Zyngier > Tested-by: Marc Zyngier > Reviewed-by: Arend Van Spriel > Reviewed-by: Franky (Zhenhui) Lin > Reviewed-by: Pieter-Paul Giesberts > Signed-off-by: Hante Meuleman > Signed-off-by: Arend van Spriel Thanks, I'm planning to push this to 4.5. -- Kalle Valo