Return-path: Received: from mail-io0-f170.google.com ([209.85.223.170]:33102 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629AbcAEKR5 (ORCPT ); Tue, 5 Jan 2016 05:17:57 -0500 MIME-Version: 1.0 In-Reply-To: <568B1C13.9050900@163.com> References: <1451894138-3482-1-git-send-email-baijiaju1990@163.com> <568B1C13.9050900@163.com> Date: Tue, 5 Jan 2016 11:17:56 +0100 Message-ID: (sfid-20160105_111818_321656_DAE4CBE6) Subject: Re: [PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits From: Helmut Schaa To: Jia-Ju Bai Cc: Stanislaw Gruszka , kvalo@codeaurora.org, linux-wireless , netdev , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Jan 5, 2016 at 2:27 AM, Jia-Ju Bai wrote: > On 01/05/2016 12:50 AM, Helmut Schaa wrote: >> >> On Mon, Jan 4, 2016 at 8:55 AM, Jia-Ju Bai wrote: >>> >>> The driver calls pci_set_mwi to enable memory-write-invalidate when it >>> is initialized, but does not call pci_clear_mwi when it is removed. Many >>> other drivers calls pci_clear_mwi when pci_set_mwi is called, such as >>> r8169, 8139cp and e1000. >>> >>> This patch adds pci_clear_mwi in error handling and removal procedure, >>> which can fix the problem. >>> >>> Signed-off-by: Jia-Ju Bai >> >> Looks good to me. >> Does this fix any actual issue? >> If yes it might we worth to mention it in the commit message. >> Helmut >> > > Lacking pci_clear_mwi may cause a resource-release omission, > but this omission may not cause obvious issues. > For reliability, it is better to add pci_clear_mwi in the driver. > Many other drivers do so, such as r8169, 8139cp and e1000. Thanks for clarification, fine with me then. Acked-by: Helmut Schaa