Return-path: Received: from mail-oi0-f43.google.com ([209.85.218.43]:36655 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753301AbcBTO3K (ORCPT ); Sat, 20 Feb 2016 09:29:10 -0500 Received: by mail-oi0-f43.google.com with SMTP id w5so30139525oie.3 for ; Sat, 20 Feb 2016 06:29:10 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <56C87303.6070203@lwfinger.net> References: <1455574327-2591-1-git-send-email-Larry.Finger@lwfinger.net> <56C87303.6070203@lwfinger.net> Date: Sat, 20 Feb 2016 23:29:09 +0900 Message-ID: (sfid-20160220_152931_644731_E0B24837) Subject: Re: [PATCH] rtlwifi: Change long delays to sleeps From: ByeoungWook Kim To: Larry Finger Cc: Kalle Valo , devel@driverdev.osuosl.org, linux-wireless Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2016-02-20 23:06 GMT+09:00 Larry Finger : > On 02/19/2016 11:48 PM, ByeoungWook Kim wrote: >> >> 2016-02-16 7:12 GMT+09:00 Larry Finger : >>> >>> Routine rtl_addr_delay() uses delay statements in code that can >>> sleep. To improve system responsiveness, the various delay statements >>> are changed. >>> >>> In addition, routines rtl_rfreg_delay() and rtl_bb_delay() are >>> rewritten to use the code in rtl_addr_delay() for most of their >>> input values. >>> >>> Suggested-by: Byeoungwook Kim >>> Signed-off-by: Larry Finger >>> --- >> >> >> Why you are using 'Suggested-by:' of me? >> I think to that your commit was included a part of my >> commit(https://patchwork.kernel.org/patch/8197071/). > > > Your commit was placed in the deferred list of patches. It did lead me to > look at that section and realize that using delays there was a bug, and that > it should be fixed as quickly as possible. That argues against waiting for > your patches to be implemented. I did use some of your changes. How do you > think I should have referenced your material? > > Larry > > I'm understood your mail. Only, I wondered why 'Suggested-by' was used. Thank for your answer. Regards, Byeoungwook