Return-path: Received: from mail-io0-f171.google.com ([209.85.223.171]:36853 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750765AbcBKXY3 (ORCPT ); Thu, 11 Feb 2016 18:24:29 -0500 MIME-Version: 1.0 In-Reply-To: <1455123535-26751-1-git-send-email-a.s.protopopov@gmail.com> References: <1455123535-26751-1-git-send-email-a.s.protopopov@gmail.com> From: Julian Calaby Date: Fri, 12 Feb 2016 10:24:09 +1100 Message-ID: (sfid-20160212_002450_121966_C8E847A8) Subject: Re: [PATCH] ath10k: fix erroneous return value To: Anton Protopopov Cc: Kalle Valo , ath10k@lists.infradead.org, linux-wireless , netdev , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi All, On Thu, Feb 11, 2016 at 3:58 AM, Anton Protopopov wrote: > The ath10k_pci_hif_exchange_bmi_msg() function may return the positive > value EIO instead of -EIO in case of error. > > Signed-off-by: Anton Protopopov This looks right to me. Reviewed-by: Julian Calaby > --- > drivers/net/wireless/ath/ath10k/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c > index ee925c6..526acde 100644 > --- a/drivers/net/wireless/ath/ath10k/pci.c > +++ b/drivers/net/wireless/ath/ath10k/pci.c > @@ -1756,7 +1756,7 @@ static int ath10k_pci_hif_exchange_bmi_msg(struct ath10k *ar, > DMA_FROM_DEVICE); > ret = dma_mapping_error(ar->dev, resp_paddr); > if (ret) { > - ret = EIO; > + ret = -EIO; > goto err_req; > } > > -- > 2.6.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/