Return-path: Received: from mail-qg0-f54.google.com ([209.85.192.54]:36523 "EHLO mail-qg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752553AbcBJRIp (ORCPT ); Wed, 10 Feb 2016 12:08:45 -0500 From: Anton Protopopov To: Johannes Berg , Emmanuel Grumbach , Kalle Valo , Eran Harary Cc: Intel Linux Wireless , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Anton Protopopov Subject: [PATCH] iwlwifi: fix erroneous return value Date: Wed, 10 Feb 2016 12:08:33 -0500 Message-Id: <1455124113-27024-1-git-send-email-a.s.protopopov@gmail.com> (sfid-20160210_180941_232035_A80CD22C) Sender: linux-wireless-owner@vger.kernel.org List-ID: The iwl_trans_pcie_start_fw() function may return the positive value EIO instead of -EIO in case of error. Signed-off-by: Anton Protopopov --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c index d60a467..920ea9d 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c @@ -1034,7 +1034,7 @@ static int iwl_trans_pcie_start_fw(struct iwl_trans *trans, if (trans_pcie->is_down) { IWL_WARN(trans, "Can't start_fw since the HW hasn't been started\n"); - ret = EIO; + ret = -EIO; goto out; } -- 2.6.5