Return-path: Received: from mail-pf0-f181.google.com ([209.85.192.181]:35639 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759934AbcBYM7P (ORCPT ); Thu, 25 Feb 2016 07:59:15 -0500 Received: by mail-pf0-f181.google.com with SMTP id c10so33702460pfc.2 for ; Thu, 25 Feb 2016 04:59:15 -0800 (PST) From: Arend Van Spriel Reply-To: arend@broadcom.com Subject: Re: [PATCH] nl80211: use ieee80211_band in kernel space References: <1456399941-8408-1-git-send-email-arend@broadcom.com> To: Arend van Spriel , Johannes Berg Cc: linux-wireless Message-ID: <56CEFA9C.1080201@broadcom.com> (sfid-20160225_135919_089832_5B6DA099) Date: Thu, 25 Feb 2016 13:59:08 +0100 MIME-Version: 1.0 In-Reply-To: <1456399941-8408-1-git-send-email-arend@broadcom.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 25-2-2016 12:32, Arend van Spriel wrote: > The enumeration nl80211_band intends to expose the public part of > ieee80211_band enumeration. As such it should not be used in the > kernel. This patch changes nl80211_band usage to ieee80211_band. > Fixes: 59ad2160c285 ("nl80211: add feature for BSS selection support") Not sure if it is any of the trees already. > Reported-by: kbuild robot > Signed-off-by: Arend van Spriel > --- > include/net/cfg80211.h | 4 ++-- > net/wireless/nl80211.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h > index 1dfb890..c6ddb69 100644 > --- a/include/net/cfg80211.h > +++ b/include/net/cfg80211.h > @@ -1863,7 +1863,7 @@ struct cfg80211_ibss_params { > * @delta: value of RSSI level adjustment. > */ > struct cfg80211_bss_select_adjust { > - enum nl80211_band band; > + enum ieee80211_band band; > s8 delta; > }; > > @@ -1878,7 +1878,7 @@ struct cfg80211_bss_select_adjust { > struct cfg80211_bss_selection { > enum nl80211_bss_select_attr behaviour; > union { > - enum nl80211_band band_pref; > + enum ieee80211_band band_pref; > struct cfg80211_bss_select_adjust adjust; > } param; > }; > diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c > index 52ce26f..1f6d8e4 100644 > --- a/net/wireless/nl80211.c > +++ b/net/wireless/nl80211.c > @@ -5786,7 +5786,7 @@ static int validate_scan_freqs(struct nlattr *freqs) > return n_channels; > } > > -static bool is_band_valid(struct wiphy *wiphy, enum nl80211_band b) > +static bool is_band_valid(struct wiphy *wiphy, enum ieee80211_band b) > { > return b < IEEE80211_NUM_BANDS && wiphy->bands[b]; > } >