Return-path: Received: from mail-yw0-f182.google.com ([209.85.161.182]:36253 "EHLO mail-yw0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364AbcBVQLb convert rfc822-to-8bit (ORCPT ); Mon, 22 Feb 2016 11:11:31 -0500 MIME-Version: 1.0 In-Reply-To: <1455826121.2084.17.camel@sipsolutions.net> References: <1454946096-9752-1-git-send-email-jprvita@endlessm.com> <1454946096-9752-8-git-send-email-jprvita@endlessm.com> <1455826121.2084.17.camel@sipsolutions.net> From: =?UTF-8?Q?Jo=C3=A3o_Paulo_Rechi_Vita?= Date: Mon, 22 Feb 2016 11:10:50 -0500 Message-ID: (sfid-20160222_171151_910847_817C0209) Subject: Re: [PATCH 7/9] rfkill: Create "rfkill-airplane_mode" LED trigger To: Johannes Berg Cc: "David S. Miller" , Darren Hart , linux-wireless , Network Development , platform-driver-x86@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, LKML , linux@endlessm.com, =?UTF-8?Q?Jo=C3=A3o_Paulo_Rechi_Vita?= Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 18 February 2016 at 15:08, Johannes Berg wrote: > On Mon, 2016-02-08 at 10:41 -0500, João Paulo Rechi Vita wrote: >> This creates a new LED trigger to be used by platform drivers as a >> default trigger for airplane-mode indicator LEDs. >> >> By default this trigger will fire when RFKILL_OP_CHANGE_ALL is called >> for all types (RFKILL_TYPE_ALL), setting the LED brightness to >> LED_FULL >> when the changing the state to blocked, and to LED_OFF when the >> changing >> the state to unblocked. In the future there will be a mechanism for >> userspace to override the default policy, so it can implement its >> own. >> >> This trigger will be used by the asus-wireless x86 platform driver. > > Just one comment - I think you should be consistent with the _ vs - and > just use "rfkill-airplane-mode" as the name. > Ok, no problem. I'll change for the next version. -- João Paulo Rechi Vita http://about.me/jprvita