Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:35567 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756490AbcBVWzP (ORCPT ); Mon, 22 Feb 2016 17:55:15 -0500 Subject: Re: [PATCH] mac80211: Let VHT work on 2.4Ghz To: Julian Calaby References: <1456180974-21062-1-git-send-email-greearb@candelatech.com> Cc: linux-wireless , Johannes Berg From: Ben Greear Message-ID: <56CB91D2.2080404@candelatech.com> (sfid-20160222_235525_268716_62CAB772) Date: Mon, 22 Feb 2016 14:55:14 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 02/22/2016 02:48 PM, Julian Calaby wrote: > Hi Ben, > > On Tue, Feb 23, 2016 at 9:42 AM, wrote: >> From: Ben Greear >> >> ath10k supports VHT on 2.4Ghz band. >> If supplicant and hostapd and radio think >> VHT should be allowed, then kernel should let them >> try. >> >> Signed-off-by: Ben Greear >> --- >> net/mac80211/mlme.c | 16 ---------------- >> net/mac80211/util.c | 13 +------------ >> net/mac80211/vht.c | 15 --------------- >> 3 files changed, 1 insertion(+), 43 deletions(-) >> >> diff --git a/net/mac80211/util.c b/net/mac80211/util.c >> index f8eb0f8..cabe16f 100644 >> --- a/net/mac80211/util.c >> +++ b/net/mac80211/util.c >> @@ -1604,17 +1603,7 @@ static int ieee80211_build_preq_ies_band(struct ieee80211_local *local, >> *offset = noffset; >> } >> >> - /* Check if any channel in this sband supports at least 80 MHz */ >> - for (i = 0; i < sband->n_channels; i++) { >> - if (sband->channels[i].flags & (IEEE80211_CHAN_DISABLED | >> - IEEE80211_CHAN_NO_80MHZ)) >> - continue; >> - >> - have_80mhz = true; >> - break; >> - } >> - >> - if (sband->vht_cap.vht_supported && have_80mhz && !disable_vht) { >> + if (sband->vht_cap.vht_supported && /*have_80mhz &&*/ !disable_vht) { > > Do you want to actually remove have_80mhz here? We do have git history > if this needs to be put back. Yes, I just missed that when cleaning up my patch. I'll wait for some other feedback and then do a -v2. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com