Return-path: Received: from mail-lf0-f50.google.com ([209.85.215.50]:35866 "EHLO mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756460AbcBQFes (ORCPT ); Wed, 17 Feb 2016 00:34:48 -0500 MIME-Version: 1.0 In-Reply-To: <87bn7gu19c.fsf@kamboji.qca.qualcomm.com> References: <20160210012216.GA18819@lianli> <20160212094526.EC572611CE@smtp.codeaurora.org> <87bn7gu19c.fsf@kamboji.qca.qualcomm.com> Date: Wed, 17 Feb 2016 16:34:46 +1100 Message-ID: (sfid-20160217_063632_327368_9223F606) Subject: Re: wlcore: Fix regression in wlcore_set_partition() From: Ross Green To: Kalle Valo Cc: Emil Goode , Shahar Patury , Guy Mishol , Igor Grinberg , Uri Mashiach , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Appreciate your efforts! Just trying to make sure it does not get lost. Introduced in rc1, not fixed by ... rc4. Anyway, I will continue to test, lots of other things still to chase even in rc4! Regards, Ross Green On Wed, Feb 17, 2016 at 2:24 AM, Kalle Valo wrote: > Ross Green writes: > >> On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo wrote: >>> >>>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a >>>> regression causing the wlcore to time out and go into recovery. Reverting the >>>> changes regarding write of the last partition size brings the module back to >>>> it's functional state. >>>> >>>> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") >>>> Reported-by: Ross Green >>>> Signed-off-by: Emil Goode >>>> [kvalo@codeaurora.org: improved commit log] >>> >>> Thanks, applied to wireless-drivers.git. >>> >>> Kalle Valo >> >> I just tested linux-4.5-rc4 it appears the above fix missed the release for rc4! >> So the behaviour of firmware reset being called after the access of >> the last partition timesout. >> >> Again tested patch with the new release - 4.5-rc4 and found everything >> to work as expected again. >> >> So Hopefully for rc5 - Please! > > It takes some time to get patches into Linus' tree. And being in a > conference and then getting sick is not really helping. I'm not sure if > this patch makes to rc5 on time, but I'll try. > > -- > Kalle Valo