Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:37680 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933225AbcBYSyt (ORCPT ); Thu, 25 Feb 2016 13:54:49 -0500 Message-ID: <56CF4DA3.8030803@codeaurora.org> (sfid-20160225_195453_422217_FDBDB447) Date: Thu, 25 Feb 2016 10:53:23 -0800 From: Peter Oh MIME-Version: 1.0 To: "Valo, Kalle" , "Oh, Peter" CC: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH v3] ath10k: set MAC timestamp in management Rx frame References: <4c705dc7a2c0aa857da4e6eaf6e8ed47c354b9ea.1456351768.git.poh@qca.qualcomm.com> <87k2lsd9zv.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87k2lsd9zv.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, On 02/25/2016 08:34 AM, Valo, Kalle wrote: > Peter Oh writes: > >> Check and set Rx MAC timestamp when firmware indicates it. >> Firmware adds it in Rx beacon frame only at this moment. >> Driver and mac80211 may utilize it to detect such clockdrift >> or beacon collision and use the result for beacon collision >> avoidance. >> >> Signed-off-by: Peter Oh >> --- >> >> v2: >> - fix kbuild test robot warning, left shift count >= width of > type, >> at __le32_to_cpu(arg.ext_info.rx_mac_timestamp_u32) << 32 >> v3: >> - correct ext_info to start 4-byte aligned >> - make struct wmi_mgmt_rx_ext_info 4-byte aligned to comply FW's > intention. > > I see new warnings: > > drivers/net/wireless/ath/ath10k/wmi.c:2199:16: warning: restricted __le32 > degrades to integer > drivers/net/wireless/ath/ath10k/wmi.c:2201:41: warning: restricted __le32 > degrades to integer > drivers/net/wireless/ath/ath10k/wmi.c:2201:41: warning: cast to restricted > __le32 > drivers/net/wireless/ath/ath10k/wmi.c:2201:41: warning: restricted __le32 > degrades to integer > Do I have a way to run this check before submitting a patch such as checkpatch.pl? Thanks, Peter