Return-path: Received: from mail-io0-f171.google.com ([209.85.223.171]:33283 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752295AbcBOAec (ORCPT ); Sun, 14 Feb 2016 19:34:32 -0500 Received: by mail-io0-f171.google.com with SMTP id z135so73762558iof.0 for ; Sun, 14 Feb 2016 16:34:31 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1455487069-2721-1-git-send-email-festevam@gmail.com> References: <1455487069-2721-1-git-send-email-festevam@gmail.com> From: Julian Calaby Date: Mon, 15 Feb 2016 11:34:11 +1100 Message-ID: (sfid-20160215_013440_936746_F8D3BE09) Subject: Re: [PATCH] brcmfmac: of: Include "of.h" header file To: Fabio Estevam Cc: Kalle Valo , Arend van Spriel , linux-wireless , Fabio Estevam Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi All, On Mon, Feb 15, 2016 at 8:57 AM, Fabio Estevam wrote: > From: Fabio Estevam > > Include "of.h" header file to fix the following sparse warning: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c:27:6: warning: symbol 'brcmf_of_probe' was not declared. Should it be static? > > Signed-off-by: Fabio Estevam Looks correct to me. Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/