Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:37162 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752262AbcBAIqH (ORCPT ); Mon, 1 Feb 2016 03:46:07 -0500 From: Hante Meuleman To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Arend van Spriel CC: Kalle Valo , "linux-wireless@vger.kernel.org" , Brett Rudley , Arend Van Spriel , "Franky (Zhenhui) Lin" , brcm80211-dev-list Subject: RE: [PATCH FIX?] brcmfmac: fix possible overflows in flowrings code by bumping u8 to u16 Date: Mon, 1 Feb 2016 08:46:04 +0000 Message-ID: (sfid-20160201_094612_068658_C130E64B) References: <1454198830-13971-1-git-send-email-zajec5@gmail.com> <56ADDA44.90707@gmail.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: SGksDQoNCkRpZG7igJl0IGtub3cgdGhhdCB0aGF0IHBhdGNoIGdvdCByZXZlcnRlZC4gT3VyIGlu dGVybmFsIHJlcG9zaXRvcnkgc3RpbGwgaGFzIHRoYXQgcGF0Y2ggYW5kIHdlIGhhdmUgaGFkIG5v IHByb2JsZW1zIHdoYXRzb2V2ZXIgZm9yIHRoZSBsYXN0IDcgKGp1bmUgMjYgdGhpcyBnb3Qgc3Vi bWl0dGVkIGludGVybmFsbHkpIG1vbnRocyBvbiBhbnkgcGNpZSB0YXJnZXQgKGFsc28gdXNlZCBp dCBvbiByODAwMCBvcGVud3J0KS4gUmFmYWwncyBwYXRjaCBpcyBvdmVyZG9uZS4gSWYgeW91IGRv buKAmXQgdXAgdGhlIGhhc2hzaXplIHNwYWNlIHRoZW4gdGhlcmUgaXMgcmVhbGx5IG5vIHVzZSB0 byBzd2l0Y2ggdG8gdTE2LiBZb3UgY2FuIHNpbXBseSBsaW1pdCB0aGUgbnIgb2YgZmxvd3Jpbmdz IHRvIDI1NSBpbiBicmNtZl9wcm90b19tc2didWZfYXR0YWNoIG9yIGFwcGx5IHRoZSBwYXRjaCBJ IG9yaWdpbmFsbHkgc3VibWl0dGVkLg0KDQpSZWdhcmRzLA0KSGFudGUNCg0KLS0tLS1PcmlnaW5h bCBNZXNzYWdlLS0tLS0NCkZyb206IFJhZmHFgiBNacWCZWNraSBbbWFpbHRvOnphamVjNUBnbWFp bC5jb21dIA0KU2VudDogU3VuZGF5LCBKYW51YXJ5IDMxLCAyMDE2IDEyOjQ0IFBNDQpUbzogQXJl bmQgdmFuIFNwcmllbA0KQ2M6IEthbGxlIFZhbG87IGxpbnV4LXdpcmVsZXNzQHZnZXIua2VybmVs Lm9yZzsgQnJldHQgUnVkbGV5OyBBcmVuZCBWYW4gU3ByaWVsOyBGcmFua3kgKFpoZW5odWkpIExp bjsgSGFudGUgTWV1bGVtYW47IGJyY204MDIxMS1kZXYtbGlzdA0KU3ViamVjdDogUmU6IFtQQVRD SCBGSVg/XSBicmNtZm1hYzogZml4IHBvc3NpYmxlIG92ZXJmbG93cyBpbiBmbG93cmluZ3MgY29k ZSBieSBidW1waW5nIHU4IHRvIHUxNg0KDQpPbiAzMSBKYW51YXJ5IDIwMTYgYXQgMTA6NTYsIEFy ZW5kIHZhbiBTcHJpZWwgPGFzcHJpZWxAZ21haWwuY29tPiB3cm90ZToNCj4gT24gMzEtMDEtMTYg MDE6MDcsIFJhZmHFgiBNacWCZWNraSB3cm90ZToNCj4+IFNvbWUgZGV2aWNlcyBtYXkgdXNlIG1v cmUgdGhhbiAyNTUgZmxvd2luZ3MsIGJlbG93IGlzIGxvZyBmcm9tIEJDTTQzNjY6DQo+PiBbICAx OTQuNjA2MjQ1XSBicmNtZm1hYzogYnJjbWZfcGNpZV9pbml0X3JpbmdidWZmZXJzIE5yIG9mIGZs b3dyaW5ncyBpcyAyNjQNCj4+DQo+PiBBdCB2YXJpb3VzIHBsYWNlcyB3ZSB3ZXJlIHVzaW5nIHU4 IHdoaWNoIGNvdWxkIGxlYWQgdG8gc3RvcmluZyB3cm9uZw0KPj4gbnVtYmVyIG9yIGluZmluaXRl IGxvb3BzIHdoZW4gaW5kZXhpbmcgaW5jb3JyZWN0bHkuIEluaXRpYWxseSB0aGlzDQo+PiBpc3N1 ZSB3YXMgc3BvdHRlZCBhcyBpbmZpbml0ZSBsb29wIGluIGJyY21mX2Zsb3dyaW5nX2RldGFjaC4N Cj4NCj4gVGhlcmUgaGFzIGFscmVhZHkgYmVlbiBhIHBhdGNoIHN1Ym1pdHRlZCBmb3IgdGhpcyBb MV0uIEhvd2V2ZXIsIGJlY2F1c2UNCj4geW91IHJlcG9ydGVkIGlzc3VlcyB3aXRoIGl0IG9uIHlv dXIgZGV2aWNlIChub3Qgc3VyZSB3aGljaCBvbmUpLiBEaWQgeW91DQo+IHRlc3QgdGhpcyBwYXRj aCBvbiB0aGF0IHBhcnRpY3VsYXIgZGV2aWNlLg0KDQpJIHdhc24ndCBhd2FyZSBIYW50ZSdzIHBh dGNoIGNvbnRhaW5lZCBjaGFuZ2VzIGZyb20gdGhpcyBwYXRjaC4gQW55d2F5DQp0aGUgbWFpbiBk aWZmZXJlbmNlIGlzIHRoYXQgbXkgcGF0Y2ggZG9lc24ndCB0b3VjaA0KQlJDTUZfRkxPV1JJTkdf SEFTSFNJWkUuDQoNClNvIG15IHBhdGNoOg0KMSkgRml4ZXMgcG9zc2libGUgb3ZlcmZsb3dzIGlu IGZsb3dyaW5ncw0KDQpIYW50ZSdzIHBhdGNoOg0KMSkgRml4ZXMgcG9zc2libGUgb3ZlcmZsb3dz IGluIGZsb3dyaW5ncw0KMikgQnVtcHMgQlJDTUZfRkxPV1JJTkdfSEFTSFNJWkUNCg0KSXQgd2Fz IGJ1bXBpbmcgQlJDTUZfRkxPV1JJTkdfSEFTSFNJWkUgdGhhdCBjYXVzZWQgcHJvYmxlbXMgb24g bXkNCkJDTTQzNjAyIGRldmljZSBiYWNrIHRoZW4uIFBsZWFzZSBub3RlIEJDTTQzNjAyIHdhc24n dCBhZmZlY3RlZCBieQ0KZmxvd2luZ3Mgb3ZlcmZsb3dzIGJlY2F1c2UgaXQgd2Fzbid0IHVzaW5n IG1vcmUgdGhhbiAyNTUgb2YgdGhlbToNCmJyY21mbWFjOiBicmNtZl9wY2llX2luaXRfcmluZ2J1 ZmZlcnMgTnIgb2YgZmxvd3JpbmdzIGlzIDEzMg0KDQpUaGUgc3RvcnkgaXMgZGlmZmVyZW50IHdp dGggbXkgQkNNNDM2Ni4gSSBkaWRuJ3QgdHJ5IGl0IHdpdGggYnVtcGluZw0KQlJDTUZfRkxPV1JJ TkdfSEFTSFNJWkUgYnV0IGl0IHN1ZmZlcnMgZnJvbSBvdmVyZmxvd3MgaW4gZmxvd3JpbmdzIGFz DQppdCBzZWVtcyB0byBiZSBpbmRlcGVuZGVudCBpc3N1ZS4gSXQncyBjcnVjaWFsIHRoYXQgQkNN NDM2NiB1c2VzIG1vcmUNCnRoYW4gMjU1IGZsb3dyaW5nczoNCmJyY21mbWFjOiBicmNtZl9wY2ll X2luaXRfcmluZ2J1ZmZlcnMgTnIgb2YgZmxvd3JpbmdzIGlzIDI2NA0KDQoNCj4gSSB3YW50IEhh bnRlIHRvIHJldmlldyB5b3VyIHBhdGNoLCBidXQgaW5kZWVkIHRoaXMgd291bGQgYmUgNC41IG1h dGVyaWFsDQo+IGFuZCBwcm9iYWJseSBzdGFibGUuDQoNCkkganVzdCByZWFsaXplZCBCQ000MzY2 IHN1cHBvcnQgd2VudCBpbnRvIDQuNCBub3QgNC41LCBzbyBDYy1pbmcNCnN0YWJsZSBmb3IgNC40 KyBpcyBwcm9iYWJseSBhIGdvb2QgaWRlYS4NCg0K